Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions.

Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions. (Closed)

Created:
8 years, 3 months ago by Aaron Boodman

Modified:
8 years, 3 months ago

Reviewers:
Yoyo Zhou, Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disallow packing or loading unpacked manifest v1 extensions. BUG=132718 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154637

Patch Set 2 : ready for review #

Patch Set 6 : blarh #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -96 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/api/extension_action/page_action_apitest.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_apitest.h	View	1 2 3 4	3 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_apitest.cc	View	1 2 3 4 5	2 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_browsertest.h	View	1 2 3 4	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_browsertest.cc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_creator.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_creator.cc	View		3 chunks	+11 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/pack_extension_job.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/pack_extension_job.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/unpacked_installer.h	View	1 2 3 4	4 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/unpacked_installer.cc	View	1 2 3 4	4 chunks	+23 lines, -27 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 2 3 4 5	2 chunks	+5 lines, -13 lines	0 comments	Download
M	chrome/common/extensions/extension_manifest_constants.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_manifest_constants.cc	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc	View	1 2 3	2 chunks	+23 lines, -28 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

LGTM https://chromiumcodereview.appspot.com/10912041/diff/3010/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): https://chromiumcodereview.appspot.com/10912041/diff/3010/chrome/common/extensions/extension.cc#newcode1361 chrome/common/extensions/extension.cc:1361: *error = ASCIIToUTF16(errors::kInvalidManifestVersionOld); You could make kModernManifestVersion into ...

8 years, 3 months ago (2012-08-31 20:50:16 UTC) #2

Aaron Boodman

http://codereview.chromium.org/10912041/diff/3010/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/10912041/diff/3010/chrome/common/extensions/extension.cc#newcode1361 chrome/common/extensions/extension.cc:1361: *error = ASCIIToUTF16(errors::kInvalidManifestVersionOld); On 2012/08/31 20:50:16, Mihai Parparita wrote: ...

8 years, 3 months ago (2012-08-31 21:03:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10912041/10001

8 years, 3 months ago (2012-08-31 21:12:56 UTC) #4

commit-bot: I haz the power

Try job failure for 10912041-10001 (retry) on mac_rel for steps "browser_tests, unit_tests". It's a second ...

8 years, 3 months ago (2012-08-31 23:13:43 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10912041/6019

8 years, 3 months ago (2012-09-02 09:49:49 UTC) #6

Change committed as 154637

Expand Messages | Collapse Messages