chrome/browser/extensions/api/extension_action/page_action_apitest.cc - Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/page_action_apitest.cc

Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: blarh Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/extension_action/page_action_apitest.cc

diff --git a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc

index b2ffd0cc780145e4274e2e7d7ce66941c4017b3c..3fd45a37e4808f6c5d2c42b50bc4cd5a7274001c 100644

--- a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc

+++ b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc

@@ -145,7 +145,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageActionRemovePopup) {

// Tests old-style pageActions API that is deprecated but we don't want to

// break.

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OldPageActions) {

- ASSERT_TRUE(RunExtensionTestIgnoreManifestWarnings("page_action/old_api")) <<

+ ASSERT_TRUE(RunExtensionTestAllowOldManifestVersion("page_action/old_api")) <<

message_;

const Extension* extension = GetSingleLoadedExtension();

ASSERT_TRUE(extension) << message_;

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/extension_apitest.h » ('j') | no next file with comments »