chrome/browser/extensions/pack_extension_job.cc - Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/pack_extension_job.cc

Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: blarh Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/pack_extension_job.cc

diff --git a/chrome/browser/extensions/pack_extension_job.cc b/chrome/browser/extensions/pack_extension_job.cc

index 5dcfd9f1beb1040e653f391f8300e1714f71e1d4..690ccc33dd4566f4c7f1fe10d46009de74337e63 100644

--- a/chrome/browser/extensions/pack_extension_job.cc

+++ b/chrome/browser/extensions/pack_extension_job.cc

@@ -22,7 +22,7 @@ PackExtensionJob::PackExtensionJob(Client* client,

const FilePath& key_file,

int run_flags)

: client_(client), key_file_(key_file), asynchronous_(true),

- run_flags_(run_flags) {

+ run_flags_(run_flags | ExtensionCreator::kRequireModernManifestVersion) {

root_directory_ = root_directory.StripTrailingSeparators();

CHECK(BrowserThread::GetCurrentThreadIdentifier(&client_thread_id_));

}