chrome/browser/extensions/pack_extension_job.h - Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/pack_extension_job.h

Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: blarh Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/pack_extension_job.h

diff --git a/chrome/browser/extensions/pack_extension_job.h b/chrome/browser/extensions/pack_extension_job.h

index 4039d197dc3276f29e1d0b3f0fdaffa477270f70..f6d0dbb49a83899035b938d2f6a1a59aa490e4b8 100644

--- a/chrome/browser/extensions/pack_extension_job.h

+++ b/chrome/browser/extensions/pack_extension_job.h

@@ -67,7 +67,8 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {

FilePath crx_file_out_;

FilePath key_file_out_;

bool asynchronous_;

- int run_flags_; // Bitset of ExtensionCreator::RunFlags values

+ int run_flags_; // Bitset of ExtensionCreator::RunFlags values - we always

+ // assume kRequireModernManifestVersion, though.

DISALLOW_COPY_AND_ASSIGN(PackExtensionJob);

};