Issue 10911085: Emit a non-zero exit code when Pub fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911085: Emit a non-zero exit code when Pub fails. (Closed)

Created:
8 years, 3 months ago by nweiz

Modified:
8 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit a non-zero exit code when Pub fails. BUG=4922 Committed: https://code.google.com/p/dart/source/detail?r=11855

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -8 lines)			Patch
M	utils/pub/pub.dart	View	3 chunks	+5 lines, -3 lines	2 comments	Download
M	utils/tests/pub/pub_install_git_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	utils/tests/pub/pub_install_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	utils/tests/pub/pub_update_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One nit, but LGTM! https://chromiumcodereview.appspot.com/10911085/diff/1/utils/pub/pub.dart File utils/pub/pub.dart (right): https://chromiumcodereview.appspot.com/10911085/diff/1/utils/pub/pub.dart#newcode222 utils/pub/pub.dart:222: future.then((_) => exit(0)); Can you ...

8 years, 3 months ago (2012-09-05 00:52:00 UTC) #2

nweiz

8 years, 3 months ago (2012-09-05 00:59:19 UTC) #3

https://chromiumcodereview.appspot.com/10911085/diff/1/utils/pub/pub.dart
File utils/pub/pub.dart (right):

https://chromiumcodereview.appspot.com/10911085/diff/1/utils/pub/pub.dart#new...
utils/pub/pub.dart:222: future.then((_) => exit(0));
On 2012/09/05 00:52:00, Bob Nystrom wrote:
> Can you add a comment here saying this is success and that we explicitly exit
to
> make sure dart:io and other async stuff is killed?

Done.

Expand Messages | Collapse Messages