Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: utils/tests/pub/pub_update_test.dart

Issue 10911085: Emit a non-zero exit code when Pub fails. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« utils/pub/pub.dart ('K') | « utils/tests/pub/pub_install_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library('pub_tests'); 5 #library('pub_tests');
6 6
7 #import('dart:io'); 7 #import('dart:io');
8 8
9 #import('test_pub.dart'); 9 #import('test_pub.dart');
10 #import('../../../pkg/unittest/unittest.dart'); 10 #import('../../../pkg/unittest/unittest.dart');
11 11
12 main() { 12 main() {
13 group('requires', () { 13 group('requires', () {
14 test('a pubspec', () { 14 test('a pubspec', () {
15 dir(appPath, []).scheduleCreate(); 15 dir(appPath, []).scheduleCreate();
16 16
17 schedulePub(args: ['update'], 17 schedulePub(args: ['update'],
18 error: const RegExp(@'^Could not find a file named "pubspec.yaml"')); 18 error: const RegExp(@'^Could not find a file named "pubspec.yaml"'),
19 exitCode: 1);
19 20
20 run(); 21 run();
21 }); 22 });
22 23
23 test('a pubspec with a "name" key', () { 24 test('a pubspec with a "name" key', () {
24 dir(appPath, [ 25 dir(appPath, [
25 pubspec({"dependencies": {"foo": null}}) 26 pubspec({"dependencies": {"foo": null}})
26 ]).scheduleCreate(); 27 ]).scheduleCreate();
27 28
28 schedulePub(args: ['update'], 29 schedulePub(args: ['update'],
29 error: const RegExp(@'^"pubspec.yaml" is missing the required "name" ' 30 error: const RegExp(@'^"pubspec.yaml" is missing the required "name" '
30 @'field \(e\.g\. "name: myapp"\)\.')); 31 @'field \(e\.g\. "name: myapp"\)\.'),
32 exitCode: 1);
31 33
32 run(); 34 run();
33 }); 35 });
34 }); 36 });
35 37
36 // TODO(rnystrom): Re-enable this when #4820 is fixed. 38 // TODO(rnystrom): Re-enable this when #4820 is fixed.
37 /* 39 /*
38 test('creates a self-referential symlink', () { 40 test('creates a self-referential symlink', () {
39 // The symlink should use the name in the pubspec, not the name of the 41 // The symlink should use the name in the pubspec, not the name of the
40 // directory. 42 // directory.
41 dir(appPath, [ 43 dir(appPath, [
42 pubspec({"name": "myapp_name"}) 44 pubspec({"name": "myapp_name"})
43 ]).scheduleCreate(); 45 ]).scheduleCreate();
44 46
45 schedulePub(args: ['update'], 47 schedulePub(args: ['update'],
46 output: const RegExp(@"Dependencies updated!$")); 48 output: const RegExp(@"Dependencies updated!$"));
47 49
48 dir(packagesPath, [ 50 dir(packagesPath, [
49 dir("myapp_name", [pubspec({"name": "myapp_name"})]) 51 dir("myapp_name", [pubspec({"name": "myapp_name"})])
50 ]).scheduleValidate(); 52 ]).scheduleValidate();
51 53
52 run(); 54 run();
53 }); 55 });
54 */ 56 */
55 } 57 }
OLDNEW
« utils/pub/pub.dart ('K') | « utils/tests/pub/pub_install_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698