Emit a non-zero exit code when Pub fails.

utils/pub/pub.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * The main entrypoint for the pub command line application.
  */
 #library('pub');
 
 #import('../../pkg/args/args.dart');
@@ skipping 166 matching lines @@
     try {
      commandOptions = commandParser.parse(commandArgs);
     } on FormatException catch (e) {
       this.printUsage(description: e.message);
       return;
     }
 
     handleError(error, trace) {
       // This is basically the top-level exception handler so that we don't
       // spew a stack trace on our users.
-      // TODO(rnystrom): Add --trace flag so stack traces can be enabled for
-      // debugging.
       var message = error.toString();
 
       // TODO(rnystrom): The default exception implementation class puts
       // "Exception:" in the output, so strip that off.
       if (message.startsWith("Exception: ")) {
         message = message.substring("Exception: ".length);
       }
 
       printError(message);
       if (globalOptions['trace'] && trace != null) {
         printError(trace);
       }
-      return true;
+
+      // TODO(nweiz): Use the more semantic error codes in
+      // http://www.freebsd.org/cgi/man.cgi?query=sysexits
+      exit(1);
     }
 
     // TODO(rnystrom): Will eventually need better logic to walk up
     // subdirectories until we hit one that looks package-like. For now, just
     // assume the cwd is it.
     var future = Package.load(workingDir, cache.sources).chain((package) {
       entrypoint = new Entrypoint(package, cache);
 
       try {
         var commandFuture = onRun();
         if (commandFuture == null) return new Future.immediate(true);
 
         return commandFuture;
       } catch (error, trace) {
         handleError(error, trace);
         return new Future.immediate(null);
       }
     });
     future.handleException((e) => handleError(e, future.stackTrace));
+    future.then((_) => exit(0));

[Bob Nystrom, 2012/09/05 00:52:00]

Can you add a comment here saying this is success and that we explicitly exit to
make sure dart:io and other async stuff is killed?

[nweiz, 2012/09/05 00:59:19]

Done.

   }
 
   /**
    * Override this to perform the specific command. Return a future that
    * completes when the command is done or fails if the command fails. If the
    * command is synchronous, it may return `null`.
    */
   abstract Future onRun();
 
   /** Displays usage information for this command. */
   void printUsage([String description]) {
     if (description == null) description = this.description;
     print(description);
     print('');
     print('Usage: $usage');
 
     var commandUsage = commandParser.getUsage();
     if (!commandUsage.isEmpty()) {
       print('');
       print(commandUsage);
     }
   }
 }