Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: utils/tests/pub/pub_install_test.dart

Issue 10911085: Emit a non-zero exit code when Pub fails. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/tests/pub/pub_install_test.dart
diff --git a/utils/tests/pub/pub_install_test.dart b/utils/tests/pub/pub_install_test.dart
index 8b7cd8670c3ecdfe3ddcc7752fd4135d54d66ece..2e0408583c6247d315bae40aadce91ebf33ef009 100644
--- a/utils/tests/pub/pub_install_test.dart
+++ b/utils/tests/pub/pub_install_test.dart
@@ -15,7 +15,8 @@ main() {
dir(appPath, []).scheduleCreate();
schedulePub(args: ['install'],
- error: const RegExp(@'^Could not find a file named "pubspec.yaml"'));
+ error: const RegExp(@'^Could not find a file named "pubspec.yaml"'),
+ exitCode: 1);
run();
});
@@ -27,7 +28,8 @@ main() {
schedulePub(args: ['install'],
error: const RegExp(@'^"pubspec.yaml" is missing the required "name" '
- @'field \(e\.g\. "name: myapp"\)\.'));
+ @'field \(e\.g\. "name: myapp"\)\.'),
+ exitCode: 1);
run();
});

Powered by Google App Engine
This is Rietveld 408576698