Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 10857037: Make FaviconService a ProfileKeyedService (Closed)

Created:
8 years, 4 months ago by andreip3000
Modified:
8 years, 4 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Make FaviconService a ProfileKeyedService BUG=112526 Looks like rlp@ already had a patch for this. My bad for not CC'ing myself to the bug...

Patch Set 1 #

Patch Set 2 : Remove spurious change to history.cc #

Patch Set 3 : Fix the tests #

Total comments: 7

Patch Set 4 : Addressed comments #

Patch Set 5 : Override Shutdown() in FaviconService to NULL the profile_ pointer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -64 lines) Patch
M chrome/browser/favicon/favicon_service.h View 1 2 3 4 3 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 1 2 3 4 6 chunks +25 lines, -35 lines 0 comments Download
A chrome/browser/favicon/favicon_service_factory.h View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/favicon/favicon_service_factory.cc View 1 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 chunks +2 lines, -11 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 4 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
andreip3000
8 years, 4 months ago (2012-08-16 15:01:04 UTC) #1
Torne
Looks reasonable to me but someone who wrote some of the favicon code should really ...
8 years, 4 months ago (2012-08-16 17:45:24 UTC) #2
andreip3000
8 years, 4 months ago (2012-08-16 17:48:03 UTC) #3
sky
Elliot should review this.
8 years, 4 months ago (2012-08-16 19:30:06 UTC) #4
Elliot Glaysher
Did you include modifications to profile_impl.h? You should be able to remove the scoped_ptr<FaviconService> now. ...
8 years, 4 months ago (2012-08-16 19:37:49 UTC) #5
joth
couple comments while passing through... https://chromiumcodereview.appspot.com/10857037/diff/8002/chrome/browser/favicon/favicon_service.cc File chrome/browser/favicon/favicon_service.cc (right): https://chromiumcodereview.appspot.com/10857037/diff/8002/chrome/browser/favicon/favicon_service.cc#newcode9 chrome/browser/favicon/favicon_service.cc:9: #include "chrome/browser/profiles/profile.h" as you ...
8 years, 4 months ago (2012-08-16 21:57:52 UTC) #6
andreip3000
Thanks for the review! https://chromiumcodereview.appspot.com/10857037/diff/8002/chrome/browser/favicon/favicon_service.cc File chrome/browser/favicon/favicon_service.cc (right): https://chromiumcodereview.appspot.com/10857037/diff/8002/chrome/browser/favicon/favicon_service.cc#newcode9 chrome/browser/favicon/favicon_service.cc:9: #include "chrome/browser/profiles/profile.h" On 2012/08/16 21:57:52, ...
8 years, 4 months ago (2012-08-17 09:34:57 UTC) #7
andreip3000
8 years, 4 months ago (2012-08-17 10:25:47 UTC) #8
Looks like rlp@ already had a patch for this. My bad for not CC'ing myself to
the bug...

http://codereview.chromium.org/10828263/

Powered by Google App Engine
This is Rietveld 408576698