Make FaviconService a ProfileKeyedService

chrome/browser/favicon/favicon_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/cancelable_request.h"
 #include "chrome/browser/history/history_types.h"
+#include "chrome/browser/profiles/profile_keyed_service.h"
 #include "chrome/common/ref_counted_util.h"
 
 class GURL;
+class HistoryService;
 class Profile;
 
 // The favicon service provides methods to access favicons. It calls the history
 // backend behind the scenes.
 //
 // This service is thread safe. Each request callback is invoked in the
 // thread that made the request.
-class FaviconService : public CancelableRequestProvider {
+class FaviconService : public CancelableRequestProvider,
+                       public ProfileKeyedService {
  public:
-  explicit FaviconService(Profile* profile);
+  // FIXME: We should not take a Profile pointer here.
+  // We do this now because we need to pass a Profile pointer to
+  // ChromeWebUIControllerFactory::GetFaviconForURL() until that
+  // component gets untangled too.
+  FaviconService(scoped_refptr<HistoryService>, Profile*);
 
   virtual ~FaviconService();
 
   // Callback for GetFavicon. If we have previously inquired about the favicon
   // for this URL, |know_favicon| will be true, and the rest of the fields will
   // be valid (otherwise they will be ignored).
   //
   // On |know_favicon| == true, |data| will either contain the PNG encoded
   // favicon data, or it will be NULL to indicate that the site does not have
   // a favicon (in other words, we know the site doesn't have a favicon, as
@@ skipping 60 matching lines @@
   // favicons will not be overwritten.
   void SetImportedFavicons(
       const std::vector<history::ImportedFaviconUsage>& favicon_usage);
 
   // Sets the favicon for a page.
   void SetFavicon(const GURL& page_url,
                   const GURL& icon_url,
                   const std::vector<unsigned char>& image_data,
                   history::IconType icon_type);
 
+  // ProfileKeyedService
+  virtual void Shutdown();
  private:
+  scoped_refptr<HistoryService> history_service_;
+  // FIXME: remove this member variable. See comment in the constructor.
   Profile* profile_;
-
   // Helper to forward an empty result if we cannot get the history service.
   void ForwardEmptyResultAsync(GetFaviconRequest* request);
 
   DISALLOW_COPY_AND_ASSIGN(FaviconService);
 };
 
 #endif  // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_