Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2917)

Unified Diff: chrome/browser/favicon/favicon_service_factory.cc

Issue 10857037: Make FaviconService a ProfileKeyedService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Override Shutdown() in FaviconService to NULL the profile_ pointer. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_service_factory.cc
diff --git a/chrome/browser/favicon/favicon_service_factory.cc b/chrome/browser/favicon/favicon_service_factory.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0d2c6ccb0071af721cc99697d4ce919327b846fc
--- /dev/null
+++ b/chrome/browser/favicon/favicon_service_factory.cc
@@ -0,0 +1,44 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/favicon/favicon_service_factory.h"
+
+#include "chrome/browser/favicon/favicon_service.h"
+#include "chrome/browser/history/history.h"
+#include "chrome/browser/history/history_service_factory.h"
+#include "chrome/browser/profiles/profile_dependency_manager.h"
+
+// static
+FaviconService* FaviconServiceFactory::GetForProfile(Profile* profile) {
+ return static_cast<FaviconService*>(
+ GetInstance()->GetServiceForProfile(profile, true));
+}
+
+// static
+FaviconServiceFactory* FaviconServiceFactory::GetInstance() {
+ return Singleton<FaviconServiceFactory>::get();
+}
+
+
+FaviconServiceFactory::FaviconServiceFactory()
+ : ProfileKeyedServiceFactory("FaviconService",
+ ProfileDependencyManager::GetInstance()) {
+ DependsOn(HistoryServiceFactory::GetInstance());
+}
+
+FaviconServiceFactory::~FaviconServiceFactory() {
+}
+
+ProfileKeyedService* FaviconServiceFactory::BuildServiceInstanceFor(
+ Profile* profile) const {
+ // FIXME: do not pass the Profile pointer to the FaviconService
+ // constructor. See comment in FaviconService.h.
+ return new FaviconService(
+ HistoryServiceFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS),
+ profile);
+}
+
+bool FaviconServiceFactory::ServiceRedirectedInIncognito() {
+ return true;
+}
« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.h ('k') | chrome/browser/profiles/profile_dependency_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698