|
|
Revert 149794 - DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING
Reviewers:
Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc
rdsmith, asanka: all
Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.*
Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.*
Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.*
Scott (sky): chrome/browser/history/history_unittest.cc
Aaron (aa): chrome/browser/extensions/webstore_installer.*
Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history.
Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing.
Review URL: https://chromiumcodereview.appspot.com/10704026
TBR=benjhayden@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150097
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+155 lines, -180 lines) |
Patch |
 |
M |
chrome/browser/automation/automation_provider.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/gdata/gdata_download_observer.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/gdata/gdata_download_observer.cc
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_item_model.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_path_reservation_tracker.cc
|
View
|
|
3 chunks |
+9 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_path_reservation_tracker_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_test_observer.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_test_observer.cc
|
View
|
|
2 chunks |
+18 lines, -14 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_util.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/downloads/downloads_api.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/downloads/downloads_api.cc
|
View
|
|
5 chunks |
+21 lines, -23 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/webstore_installer.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/webstore_installer.cc
|
View
|
|
2 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_unittest.cc
|
View
|
|
4 chunks |
+9 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/plugin_installer.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/plugin_installer.cc
|
View
|
|
2 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/download/download_item_mac.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/download/download_item_mac.mm
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
MM |
chrome/browser/ui/gtk/download/download_item_gtk.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/download/download_item_gtk.cc
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/download/download_item_view.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/download/download_item_view.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/downloads_dom_handler.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/downloads_dom_handler.cc
|
View
|
|
2 chunks |
+8 lines, -11 lines |
0 comments
|
Download
|
|
M |
content/browser/download/download_item_impl.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/browser/download/download_item_impl.cc
|
View
|
|
3 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/browser/download/download_item_impl_unittest.cc
|
View
|
|
3 chunks |
+3 lines, -40 lines |
0 comments
|
Download
|
|
M |
content/browser/download/download_manager_impl.cc
|
View
|
|
5 chunks |
+25 lines, -9 lines |
0 comments
|
Download
|
|
M |
content/browser/download/drag_download_file.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/browser/download/drag_download_file.cc
|
View
|
|
2 chunks |
+2 lines, -12 lines |
0 comments
|
Download
|
|
M |
content/browser/download/save_package.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/download/save_package.cc
|
View
|
|
1 chunk |
+9 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/public/browser/download_item.h
|
View
|
|
2 chunks |
+6 lines, -10 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
10837125:
Revert 149794 - DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed)
