Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 10837125: Revert 149794 - DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1228/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/download/download_item_view.cc
===================================================================
--- chrome/browser/ui/views/download/download_item_view.cc (revision 150095)
+++ chrome/browser/ui/views/download/download_item_view.cc (working copy)
@@ -297,6 +297,9 @@
StopDownloadProgress();
LoadIcon();
break;
+ case DownloadItem::REMOVING:
+ parent_->RemoveDownloadView(this); // This will delete us!
+ return;
default:
NOTREACHED();
}
@@ -317,10 +320,6 @@
parent()->SchedulePaint();
}
-void DownloadItemView::OnDownloadDestroyed(DownloadItem* download) {
- parent_->RemoveDownloadView(this); // This will delete us!
-}
-
void DownloadItemView::OnDownloadOpened(DownloadItem* download) {
disabled_while_opening_ = true;
SetEnabled(false);
« no previous file with comments | « chrome/browser/ui/views/download/download_item_view.h ('k') | chrome/browser/ui/webui/downloads_dom_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698