Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/browser/ui/cocoa/download/download_item_mac.mm

Issue 10837125: Revert 149794 - DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1228/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/download/download_item_mac.mm
===================================================================
--- chrome/browser/ui/cocoa/download/download_item_mac.mm (revision 150095)
+++ chrome/browser/ui/cocoa/download/download_item_mac.mm (working copy)
@@ -46,6 +46,9 @@
}
switch (download->GetState()) {
+ case DownloadItem::REMOVING:
+ [item_controller_ remove]; // We're deleted now!
+ break;
case DownloadItem::COMPLETE:
if (download->GetAutoOpened()) {
[item_controller_ remove]; // We're deleted now!
@@ -66,10 +69,6 @@
}
}
-void DownloadItemMac::OnDownloadDestroyed(content::DownloadItem* download) {
- [item_controller_ remove]; // We're deleted now!
-}
-
void DownloadItemMac::OnDownloadOpened(content::DownloadItem* download) {
DCHECK_EQ(download, download_model_->download());
[item_controller_ downloadWasOpened];
« no previous file with comments | « chrome/browser/ui/cocoa/download/download_item_mac.h ('k') | chrome/browser/ui/gtk/download/download_item_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698