content/browser/download/save_package.cc - Issue 10837125: Revert 149794 - DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_package.cc

Issue 10837125: Revert 149794 - DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1228/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/save_package.cc

===================================================================

--- content/browser/download/save_package.cc (revision 150095)

+++ content/browser/download/save_package.cc (working copy)

@@ -1358,8 +1358,15 @@

download_manager_ = NULL;

}

-void SavePackage::OnDownloadDestroyed(DownloadItem* download) {

- StopObservation();

+void SavePackage::OnDownloadUpdated(DownloadItem* download) {

+ DCHECK(download_);

+ DCHECK(download_ == download);

+ DCHECK(download_manager_);

+ // Check for removal.

+ if (download_->GetState() == DownloadItem::REMOVING) {

+ StopObservation();

+ }

}

void SavePackage::FinalizeDownloadEntry() {

« no previous file with comments | « content/browser/download/save_package.h ('k') | content/public/browser/download_item.h » ('j') | no next file with comments »