Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 10837083: Merge 149283 - This fixes connecting to hidden networks by not marking (Closed)

Created:
8 years, 4 months ago by Greg Spencer (Chromium)
Modified:
8 years, 4 months ago
Reviewers:
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Merge 149283 - This fixes connecting to hidden networks by not marking them failed when they fail to show up in the wifi scan (they're hidden, so they aren't expected to show up). MERGE NOTE: Not merged with drover because of patch failure (diff line offset was too large to match, so had to patch manually). TBR=gspencer@chromium.org BUG=chromium:137273 TEST=Ran on device, tested connection to hidden network multiple times with no failure. Original Review URL: https://chromiumcodereview.appspot.com/10849003 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/browser/chromeos/cros/network_library.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_base.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698