Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/browser/chromeos/cros/network_library.cc

Issue 10837083: Merge 149283 - This fixes connecting to hidden networks by not marking (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/network_library_impl_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/network_library.cc
===================================================================
--- chrome/browser/chromeos/cros/network_library.cc (revision 149702)
+++ chrome/browser/chromeos/cros/network_library.cc (working copy)
@@ -288,13 +288,16 @@
// CONNECT_REQUESTED is set internally. Shill/flimflam do not update the
// state immediately, so ignore any Idle state updates sent while a
// connection attempt is in progress.
+ VLOG(2) << "Ignoring idle state change after connection request.";
return;
}
ConnectionState old_state = state_;
+ VLOG(2) << "Entering new state: " << ConnectionStateString(new_state);
state_ = new_state;
if (!IsConnectingState(new_state))
set_connection_started(false);
if (new_state == STATE_FAILURE) {
+ VLOG(2) << "Detected Failure state.";
if (old_state != STATE_UNKNOWN &&
old_state != STATE_IDLE) {
// New failure, the user needs to be notified.
@@ -303,8 +306,10 @@
notify_failure_ = true;
// Normally error_ should be set, but if it is not we need to set it to
// something here so that the retry logic will be triggered.
- if (error_ == ERROR_NO_ERROR)
+ if (error_ == ERROR_NO_ERROR) {
+ VLOG(2) << "Detected NO_ERROR error state. Setting to UNKNOWN.";
error_ = ERROR_UNKNOWN;
+ }
}
} else {
// State changed, so refresh IP address.
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/network_library_impl_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698