This fixes connecting to hidden networks by not marking them failed

This fixes connecting to hidden networks by not marking them failed
when they fail to show up in the wifi scan (they're hidden, so they
aren't expected to show up).

BUG=chromium:137273
TEST=Ran on device, tested connection to hidden network multiple times
     with no failure.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149283

[stevenjb, 2012-07-31 19:10:52]

lgtm

http://codereview.chromium.org/10849003/diff/2001/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/network_library_impl_cros.cc (right):

http://codereview.chromium.org/10849003/diff/2001/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/network_library_impl_cros.cc:849: !(wifi &&
wifi->hidden_ssid())) {
nit: alignment

[commit-bot: I haz the power, 2012-07-31 19:15:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10849003/2002

[commit-bot: I haz the power, 2012-07-31 19:40:30]

Try job failure for 10849003-2002 (retry) on mac_rel for steps "base_unittests,
browser_tests, cacheinvalidation_unittests, jingle_unittests,
remoting_unittests, interactive_ui_tests, crypto_unittests, net_unittests,
unit_tests, gpu_unittests, nacl_integration, media_unittests,
safe_browsing_tests, ipc_tests, printing_unittests, sql_unittests,
content_unittests, sync_unit_tests".
It's a second try, previously, steps "base_unittests, browser_tests,
cacheinvalidation_unittests, jingle_unittests, remoting_unittests,
interactive_ui_tests, crypto_unittests, net_unittests, unit_tests,
gpu_unittests, nacl_integration, media_unittests, safe_browsing_tests,
ipc_tests, printing_unittests, sql_unittests, content_unittests,
sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-31 20:02:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10849003/2002

[Paul Stewart, 2012-07-31 20:21:32]

http://codereview.chromium.org/10849003/diff/2002/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/network_library_impl_cros.cc (right):

http://codereview.chromium.org/10849003/diff/2002/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/network_library_impl_cros.cc:849: !(wifi &&
wifi->hidden_ssid())) {
This says we should disable this check for all non-WiFi networks as well.  Was
this what you wanted to do?

[Greg Spencer (Chromium), 2012-07-31 20:27:10]

http://codereview.chromium.org/10849003/diff/2002/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/network_library_impl_cros.cc (right):

http://codereview.chromium.org/10849003/diff/2002/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/network_library_impl_cros.cc:849: !(wifi &&
wifi->hidden_ssid())) {
On 2012/07/31 20:21:32, Paul Stewart wrote:
> This says we should disable this check for all non-WiFi networks as well.  Was
> this what you wanted to do?

No that's not the correct interpretation, because |wifi| will be NULL (false) in
that case, so it will get run if it's not a wifi network or if it's a wifi
network without a hidden SSID.

[Paul Stewart, 2012-07-31 20:29:52]

http://codereview.chromium.org/10849003/diff/2002/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/network_library_impl_cros.cc (right):

http://codereview.chromium.org/10849003/diff/2002/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/network_library_impl_cros.cc:849: !(wifi &&
wifi->hidden_ssid())) {
Sorry.  Yeah, that's right.

[commit-bot: I haz the power, 2012-07-31 21:46:17]

Change committed as 149283