Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/chromeos/cros/network_library_impl_cros.cc

Issue 10837083: Merge 149283 - This fixes connecting to hidden networks by not marking (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/cros/network_library_impl_base.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/network_library_impl_cros.cc
===================================================================
--- chrome/browser/chromeos/cros/network_library_impl_cros.cc (revision 149702)
+++ chrome/browser/chromeos/cros/network_library_impl_cros.cc (working copy)
@@ -843,11 +843,16 @@
<< " State = " << network->GetStateString()
<< " connecting = " << network->connecting()
<< " connection_started = " << network->connection_started();
+ WifiNetwork* wifi = NULL;
+ if (network->type() == TYPE_WIFI)
+ wifi = static_cast<WifiNetwork*>(network);
if (network->failed() && network->notify_failure()) {
// We have not notified observers of a connection failure yet.
AddNetwork(network);
- } else if (network->connecting() && network->connection_started()) {
- // Network was in connecting state; set state to failed.
+ } else if (network->connecting() && network->connection_started() &&
+ !(wifi && wifi->hidden_ssid())) {
+ // Network was in connecting state; set state to failed, but not if it
+ // had a hidden SSID (since that won't appear in the scanning list).
VLOG(2) << "Removed network was connecting: " << network->name();
network->SetState(STATE_FAILURE);
AddNetwork(network);
« no previous file with comments | « chrome/browser/chromeos/cros/network_library_impl_base.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698