Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 10837061: gdata: Make WeakPtrFactory the last parameter (Closed)

Created:
8 years, 4 months ago by satorux1
Modified:
8 years, 4 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Make WeakPtrFactory the last parameter Remove WeakPtr members in favor of WeakPtrFactory::GetWeakPtr() Along the way, copy derat's comment from ContactDatabase on this matter. Wez on [chromium-dev] Weak ptrs for derived types? You need to be similarly careful to have WeakPtrFactory appear after any fields that its WeakPtrs may be used to access if you follow that pattern instead. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149576

Patch Set 1 #

Patch Set 2 : rebase and reorder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -123 lines) Patch
M chrome/browser/chromeos/gdata/gdata_auth_service.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_auth_service.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_cache.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_cache.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_download_observer.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 1 83 chunks +93 lines, -88 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operation_runner.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operation_runner.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_sync_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_uploader.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_uploader.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gdata/operations_base.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
8 years, 4 months ago (2012-08-01 23:03:13 UTC) #1
Daniel Erat
lgtm
8 years, 4 months ago (2012-08-01 23:06:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/10837061/1
8 years, 4 months ago (2012-08-02 00:11:39 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 00:49:06 UTC) #4
Try job failure for 10837061-1 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Powered by Google App Engine
This is Rietveld 408576698