|
gdata: Make WeakPtrFactory the last parameter
Remove WeakPtr members in favor of WeakPtrFactory::GetWeakPtr()
Along the way, copy derat's comment from ContactDatabase on this matter.
Wez on [chromium-dev] Weak ptrs for derived types?
You need to be similarly careful to have WeakPtrFactory appear after any
fields that its WeakPtrs may be used to access if you follow that pattern
instead.
BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149576
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+136 lines, -123 lines) |
Patch |
 |
M |
chrome/browser/chromeos/gdata/gdata_auth_service.h
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_auth_service.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_cache.h
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_cache.cc
|
View
|
|
5 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_download_observer.h
|
View
|
|
3 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_file_system.h
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_file_system.cc
|
View
|
1
|
83 chunks |
+93 lines, -88 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_operation_runner.h
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_operation_runner.cc
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_sync_client.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_uploader.h
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/gdata_uploader.cc
|
View
|
|
6 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/gdata/operations_base.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|