Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: chrome/browser/chromeos/gdata/gdata_operation_runner.h

Issue 10837061: gdata: Make WeakPtrFactory the last parameter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase and reorder Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_operation_runner.h
diff --git a/chrome/browser/chromeos/gdata/gdata_operation_runner.h b/chrome/browser/chromeos/gdata/gdata_operation_runner.h
index e58c47dfa4cad648ed795ef438b2c39d00841eec..a5bbc464a085fcdf35ad07e88967228cc324e00b 100644
--- a/chrome/browser/chromeos/gdata/gdata_operation_runner.h
+++ b/chrome/browser/chromeos/gdata/gdata_operation_runner.h
@@ -69,8 +69,10 @@ class GDataOperationRunner : public GDataAuthService::Observer {
scoped_ptr<GDataAuthService> auth_service_;
scoped_ptr<GDataOperationRegistry> operation_registry_;
+
+ // Note: This should remain the last member so it'll be destroyed and
+ // invalidate its weak pointers before any other members are destroyed.
base::WeakPtrFactory<GDataOperationRunner> weak_ptr_factory_;
- base::WeakPtr<GDataOperationRunner> weak_ptr_bound_to_ui_thread_;
DISALLOW_COPY_AND_ASSIGN(GDataOperationRunner);
};
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system.cc ('k') | chrome/browser/chromeos/gdata/gdata_operation_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698