Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/browser/chromeos/gdata/gdata_auth_service.h

Issue 10837061: gdata: Make WeakPtrFactory the last parameter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase and reorder Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_auth_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_auth_service.h
diff --git a/chrome/browser/chromeos/gdata/gdata_auth_service.h b/chrome/browser/chromeos/gdata/gdata_auth_service.h
index 1acfac25a08fdf4cf56bd320b09579436dd9d796..a79fa236ad80c5d61099b7981696fc346ed98b46 100644
--- a/chrome/browser/chromeos/gdata/gdata_auth_service.h
+++ b/chrome/browser/chromeos/gdata/gdata_auth_service.h
@@ -98,8 +98,10 @@ class GDataAuthService : public content::NotificationObserver {
ObserverList<Observer> observers_;
content::NotificationRegistrar registrar_;
+
+ // Note: This should remain the last member so it'll be destroyed and
+ // invalidate its weak pointers before any other members are destroyed.
base::WeakPtrFactory<GDataAuthService> weak_ptr_factory_;
- base::WeakPtr<GDataAuthService> weak_ptr_bound_to_ui_thread_;
DISALLOW_COPY_AND_ASSIGN(GDataAuthService);
};
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_auth_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698