chrome/browser/chromeos/gdata/gdata_uploader.h - Issue 10837061: gdata: Make WeakPtrFactory the last parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/gdata/gdata_uploader.h

Issue 10837061: gdata: Make WeakPtrFactory the last parameter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase and reorder Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/gdata/gdata_uploader.h

diff --git a/chrome/browser/chromeos/gdata/gdata_uploader.h b/chrome/browser/chromeos/gdata/gdata_uploader.h

index 970bede7d36a9df2bc2fa7cab286540894cb0af2..232d1e067e53b00cb15eb71eeccd0dda9ec57df4 100644

--- a/chrome/browser/chromeos/gdata/gdata_uploader.h

+++ b/chrome/browser/chromeos/gdata/gdata_uploader.h

@@ -134,8 +134,9 @@ class GDataUploader : public GDataUploaderInterface {

typedef std::map<int, UploadFileInfo*> UploadFileInfoMap;

UploadFileInfoMap pending_uploads_;

- // Factory for various callbacks.

- base::WeakPtrFactory<GDataUploader> uploader_factory_;

+ // Note: This should remain the last member so it'll be destroyed and

+ // invalidate its weak pointers before any other members are destroyed.

+ base::WeakPtrFactory<GDataUploader> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(GDataUploader);

};