Move AudioDevice and AudioInputDevice to media.

Move AudioDevice and AudioInputDevice to media.

This CL does the following:
* Move AudioDevice, AudioInputDevice out of content, into media/audio.
* ...and a couple of dependent classes: AudioDeviceThread and ScopedLoopObserver.
* ...and the unit test.
* Renamed AudioDevice -> AudioOutputDevice
* Moved the classes into the media namespace.
* Updated the unit test code as necessary.

Aside from the unit test*, there are minimal code changes.  Only what was required to make things build and work as before - mostly just adding or removing "media::".

* The unit test changes were to add expectations for AddDelegate/RemoveDelegate since previously a mock class was inheriting from AudioMessageFilter and not the IPC interface.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148777

[tommi (sloooow) - chröme, 2012-07-26 15:28:07]

Andrew and John: I need owners and the script picked out you guys as victims! :)

Henrik: Main review.

[jam, 2012-07-26 15:34:43]

why is no change history preserved? i.e. why are the files "A" instead of "A+"?

[tommi (sloooow) - chröme, 2012-07-26 15:38:01]

I don't know.  I used "git mv" thinking that history would be properly
preserved, should I have used something else?


On Thu, Jul 26, 2012 at 5:34 PM, <jam@chromium.org> wrote:

> why is no change history preserved? i.e. why are the files "A" instead of
> "A+"?
>
>
http://codereview.chromium.**org/10834033/<http://codereview.chromium.org/108...
>

[jam, 2012-07-26 15:55:06]

On 2012/07/26 15:38:01, tommi wrote:
> I don't know.  I used "git mv" thinking that history would be properly
> preserved, should I have used something else?

I'm not familiar with git, so not sure which commands should be used. I'll defer
to git experts to figure out how to retain file history.

[scherkus (not reviewing), 2012-07-26 16:16:29]

On 2012/07/26 15:55:06, John Abd-El-Malek wrote:
> On 2012/07/26 15:38:01, tommi wrote:
> > I don't know.  I used "git mv" thinking that history would be properly
> > preserved, should I have used something else?
> 
> I'm not familiar with git, so not sure which commands should be used. I'll
defer
> to git experts to figure out how to retain file history.

git usually detects file moves -- I'm actually surprised it didn't figure this
one out

tommi: IANA Git Expert, but perhaps you need to squash your patchsets into one?

[scherkus (not reviewing), 2012-07-26 17:19:01]

lgtm but it'd be nice to get history preserved -- it's a bit hard to figure out
what has changed

[henrika (OOO until Aug 14), 2012-07-27 07:35:02]

Some info on the history stuff can be found here:

https://groups.google.com/a/chromium.org/forum/?fromgroups#!searchin/chromium...


On Thu, Jul 26, 2012 at 7:19 PM, <scherkus@chromium.org> wrote:

> lgtm but it'd be nice to get history preserved -- it's a bit hard to
> figure out
> what has changed
>
>
http://codereview.chromium.**org/10834033/<http://codereview.chromium.org/108...
>

[tommi (sloooow) - chröme, 2012-07-27 08:23:46]

On 2012/07/27 07:35:02, henrika wrote:
> Some info on the history stuff can be found here:
> 
>
https://groups.google.com/a/chromium.org/forum/?fromgroups#%21searchin/chromi...
> 
> 
> On Thu, Jul 26, 2012 at 7:19 PM, <mailto:scherkus@chromium.org> wrote:
> 
> > lgtm but it'd be nice to get history preserved -- it's a bit hard to
> > figure out
> > what has changed
> >
> >
>
http://codereview.chromium.**org/10834033/%3Chttp://codereview.chromium.org/1...>
> >

Thanks Henrik. I tried using some of the tricks in that thread but to no avail. 
Git lists the file as being moved, but it gets lost in svn translation:

M       content/content_renderer.gypi
M       content/content_tests.gypi
M       content/renderer/media/audio_device_factory.cc
M       content/renderer/media/audio_device_factory.h
M       content/renderer/media/audio_renderer_mixer_manager.h
M       content/renderer/media/audio_renderer_mixer_manager_unittest.cc
M       content/renderer/media/render_audiosourceprovider.cc
M       content/renderer/media/render_audiosourceprovider.h
M       content/renderer/media/webrtc_audio_device_impl.cc
M       content/renderer/media/webrtc_audio_device_impl.h
M       content/renderer/pepper/pepper_platform_audio_output_impl.h
M       content/renderer/renderer_webkitplatformsupport_impl.cc
M       content/test/webrtc_audio_device_test.cc
R097    content/renderer/media/audio_device_thread.cc  
media/audio/audio_device_thread.cc
R090    content/renderer/media/audio_device_thread.h   
media/audio/audio_device_thread.h
R090    content/renderer/media/audio_input_device.cc   
media/audio/audio_input_device.cc
R086    content/renderer/media/audio_input_device.h    
media/audio/audio_input_device.h
R070    content/renderer/media/audio_device.cc 
media/audio/audio_output_device.cc
R073    content/renderer/media/audio_device.h  
media/audio/audio_output_device.h
R067    content/renderer/media/audio_device_unittest.cc
media/audio/audio_output_device_unittest.cc
M       media/audio/audio_output_ipc.h
M       media/audio/mac/audio_manager_mac.cc
R093    content/renderer/media/scoped_loop_observer.cc 
media/audio/scoped_loop_observer.cc
R085    content/renderer/media/scoped_loop_observer.h  
media/audio/scoped_loop_observer.h
M       media/media.gyp

[tommi (sloooow) - chröme, 2012-07-27 08:24:14]

will retry this using an svn repo. stay tuned.

[tommi (sloooow) - chröme, 2012-07-27 10:11:00]

svn ftw!  diffs show up correctly now and history preserved.  ptal.

[henrika (OOO until Aug 14), 2012-07-27 11:08:49]

Whoa-oa-oa! I feel good, I knew that I would, now
I feel good, I knew that I would, now
So good, so good, I got you.

LGTM w/ nits.

[henrika (OOO until Aug 14), 2012-07-27 11:08:57]

https://chromiumcodereview.appspot.com/10834033/diff/10003/content/renderer/m...
File content/renderer/media/audio_device_factory.h (right):

https://chromiumcodereview.appspot.com/10834033/diff/10003/content/renderer/m...
content/renderer/media/audio_device_factory.h:21: // This class uses the same
pattern as content::RenderViewHostFactory.
I think we can remove this sentence. "This class uses..."

https://chromiumcodereview.appspot.com/10834033/diff/10003/media/audio/audio_...
File media/audio/audio_device_thread.h (right):

https://chromiumcodereview.appspot.com/10834033/diff/10003/media/audio/audio_...
media/audio/audio_device_thread.h:35: // AudioOutputDevice thread.
Add AudioInputDevice thread and update AudioInputDevice class.

[tommi (sloooow) - chröme, 2012-07-27 11:40:05]

https://chromiumcodereview.appspot.com/10834033/diff/10003/content/renderer/m...
File content/renderer/media/audio_device_factory.h (right):

https://chromiumcodereview.appspot.com/10834033/diff/10003/content/renderer/m...
content/renderer/media/audio_device_factory.h:21: // This class uses the same
pattern as content::RenderViewHostFactory.
On 2012/07/27 11:08:57, henrika wrote:
> I think we can remove this sentence. "This class uses..."

Done.

https://chromiumcodereview.appspot.com/10834033/diff/10003/media/audio/audio_...
File media/audio/audio_device_thread.h (right):

https://chromiumcodereview.appspot.com/10834033/diff/10003/media/audio/audio_...
media/audio/audio_device_thread.h:35: // AudioOutputDevice thread.
On 2012/07/27 11:08:57, henrika wrote:
> Add AudioInputDevice thread and update AudioInputDevice class.

Done.

[jam, 2012-07-27 16:12:31]

lgtm, thanks :)

[commit-bot: I haz the power, 2012-07-27 16:42:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommi@chromium.org/10834033/1065

[commit-bot: I haz the power, 2012-07-27 16:43:01]

Failed to apply patch for media/audio/audio_device_thread.cc:
While running patch -p0 --forward --force;
patching file media/audio/audio_device_thread.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 13.
Hunk #3 FAILED at 170.
Hunk #4 FAILED at 200.
4 out of 4 hunks FAILED -- saving rejects to file
media/audio/audio_device_thread.cc.rej

[tommi (sloooow) - chröme, 2012-07-27 16:45:32]

On 2012/07/27 16:43:01, I haz the power (commit-bot) wrote:
> Failed to apply patch for media/audio/audio_device_thread.cc:
> While running patch -p0 --forward --force;
> patching file media/audio/audio_device_thread.cc
> Hunk #1 FAILED at 2.
> Hunk #2 FAILED at 13.
> Hunk #3 FAILED at 170.
> Hunk #4 FAILED at 200.
> 4 out of 4 hunks FAILED -- saving rejects to file
> media/audio/audio_device_thread.cc.rej

Looks like cq is expecting a git patch. I'll commit manually.

[jam, 2012-07-30 15:17:26]

On 2012/07/27 16:45:32, tommi wrote:
> On 2012/07/27 16:43:01, I haz the power (commit-bot) wrote:
> > Failed to apply patch for media/audio/audio_device_thread.cc:
> > While running patch -p0 --forward --force;
> > patching file media/audio/audio_device_thread.cc
> > Hunk #1 FAILED at 2.
> > Hunk #2 FAILED at 13.
> > Hunk #3 FAILED at 170.
> > Hunk #4 FAILED at 200.
> > 4 out of 4 hunks FAILED -- saving rejects to file
> > media/audio/audio_device_thread.cc.rej
> 
> Looks like cq is expecting a git patch. I'll commit manually.

CQ works with svn. I think the issue is that there were conflicts that it
couldn't resolve.

[tommi (sloooow) - chröme, 2012-07-30 15:44:35]

Yes, I know that svn and cq work. :)

What I think was the problem was that since the cl started out with git,
that's how cq attempted to apply it.
Svn diff files are slightly different, so applying an svn patch with git
parameters (note the "-p0" in the output), is not going to work.
That's how I interpreted the output of the error at least.

In any case, I simply landed the cl manually without problems.


On Mon, Jul 30, 2012 at 5:17 PM, <jam@chromium.org> wrote:

> On 2012/07/27 16:45:32, tommi wrote:
>
>> On 2012/07/27 16:43:01, I haz the power (commit-bot) wrote:
>> > Failed to apply patch for media/audio/audio_device_**thread.cc:
>> > While running patch -p0 --forward --force;
>> > patching file media/audio/audio_device_**thread.cc
>> > Hunk #1 FAILED at 2.
>> > Hunk #2 FAILED at 13.
>> > Hunk #3 FAILED at 170.
>> > Hunk #4 FAILED at 200.
>> > 4 out of 4 hunks FAILED -- saving rejects to file
>> > media/audio/audio_device_**thread.cc.rej
>>
>
>  Looks like cq is expecting a git patch. I'll commit manually.
>>
>
> CQ works with svn. I think the issue is that there were conflicts that it
> couldn't resolve.
>
>
http://codereview.chromium.**org/10834033/<http://codereview.chromium.org/108...
>

[jam, 2012-07-30 16:05:09]

On Mon, Jul 30, 2012 at 8:44 AM, Tommi <tommi@chromium.org> wrote:

> Yes, I know that svn and cq work. :)
>
> What I think was the problem was that since the cl started out with git,
> that's how cq attempted to apply it.
> Svn diff files are slightly different, so applying an svn patch with git
> parameters (note the "-p0" in the output), is not going to work.
> That's how I interpreted the output of the error at least.
>

oh, i always do patch -p0 -i foo.patch even when applying svn patches.

I interpreted the output as a conflict. Out of curiosity, when you landed
it manually, did you have conflicts that you had to merge?

>
> In any case, I simply landed the cl manually without problems.
>
>
> On Mon, Jul 30, 2012 at 5:17 PM, <jam@chromium.org> wrote:
>
>> On 2012/07/27 16:45:32, tommi wrote:
>>
>>> On 2012/07/27 16:43:01, I haz the power (commit-bot) wrote:
>>> > Failed to apply patch for media/audio/audio_device_**thread.cc:
>>> > While running patch -p0 --forward --force;
>>> > patching file media/audio/audio_device_**thread.cc
>>> > Hunk #1 FAILED at 2.
>>> > Hunk #2 FAILED at 13.
>>> > Hunk #3 FAILED at 170.
>>> > Hunk #4 FAILED at 200.
>>> > 4 out of 4 hunks FAILED -- saving rejects to file
>>> > media/audio/audio_device_**thread.cc.rej
>>>
>>
>>  Looks like cq is expecting a git patch. I'll commit manually.
>>>
>>
>> CQ works with svn. I think the issue is that there were conflicts that it
>> couldn't resolve.
>>
>>
http://codereview.chromium.**org/10834033/<http://codereview.chromium.org/108...
>>
>
>

[tommi (sloooow) - chröme, 2012-07-30 16:39:59]

Nope, no conflicts, flew right in.


On Mon, Jul 30, 2012 at 6:05 PM, John Abd-El-Malek <jam@chromium.org> wrote:

>
>
> On Mon, Jul 30, 2012 at 8:44 AM, Tommi <tommi@chromium.org> wrote:
>
>> Yes, I know that svn and cq work. :)
>>
>> What I think was the problem was that since the cl started out with git,
>> that's how cq attempted to apply it.
>> Svn diff files are slightly different, so applying an svn patch with git
>> parameters (note the "-p0" in the output), is not going to work.
>> That's how I interpreted the output of the error at least.
>>
>
> oh, i always do patch -p0 -i foo.patch even when applying svn patches.
>
> I interpreted the output as a conflict. Out of curiosity, when you landed
> it manually, did you have conflicts that you had to merge?
>
>>
>> In any case, I simply landed the cl manually without problems.
>>
>>
>> On Mon, Jul 30, 2012 at 5:17 PM, <jam@chromium.org> wrote:
>>
>>> On 2012/07/27 16:45:32, tommi wrote:
>>>
>>>> On 2012/07/27 16:43:01, I haz the power (commit-bot) wrote:
>>>> > Failed to apply patch for media/audio/audio_device_**thread.cc:
>>>> > While running patch -p0 --forward --force;
>>>> > patching file media/audio/audio_device_**thread.cc
>>>> > Hunk #1 FAILED at 2.
>>>> > Hunk #2 FAILED at 13.
>>>> > Hunk #3 FAILED at 170.
>>>> > Hunk #4 FAILED at 200.
>>>> > 4 out of 4 hunks FAILED -- saving rejects to file
>>>> > media/audio/audio_device_**thread.cc.rej
>>>>
>>>
>>>  Looks like cq is expecting a git patch. I'll commit manually.
>>>>
>>>
>>> CQ works with svn. I think the issue is that there were conflicts that it
>>> couldn't resolve.
>>>
>>>
http://codereview.chromium.**org/10834033/<http://codereview.chromium.org/108...
>>>
>>
>>
>