Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10832282: Replace views::MouseEvent with ui::MouseEvent (Closed)

Created:
8 years, 4 months ago by Ben Goodger (Google)
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, penghuang+watch_chromium.org, jennb, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, Dmitry Titov, dcheng, Randy Smith (Not in Mondays), Aaron Boodman, mihaip-chromium-reviews_chromium.org, jianli, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+677 lines, -674 lines) Patch
M ash/desktop_background/desktop_background_view.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/app_list_button.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M ash/launcher/app_list_button.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M ash/launcher/launcher_button.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M ash/launcher/launcher_button.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M ash/launcher/launcher_view_unittest.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M ash/shell/window_type_launcher.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_type_launcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_view.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/date/date_view.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_background_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bubble_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_notification_view.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_notification_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M ash/system/tray/tray_views.cc View 1 2 4 chunks +8 lines, -11 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/test/capture_tracking_view.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/test/capture_tracking_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_bubble_controller.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/partial_screenshot_view.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/partial_screenshot_view.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_view.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/event_disposition.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_frame_view.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_frame_view.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_action_view.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_action_view.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/chrome_to_mobile_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/ev_bubble_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/ev_bubble_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/reload_button.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/reload_button.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/reload_button_unittest.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.cc View 1 2 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 8 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_result_list_view.cc View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M ui/base/event.h View 1 2 2 chunks +30 lines, -1 line 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/button_dropdown.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/button/button_dropdown.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 1 2 7 chunks +18 lines, -12 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/radio_button.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_views.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_views.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/label.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/label.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/link.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/link.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 2 7 chunks +19 lines, -17 lines 0 comments Download
M ui/views/controls/menu/menu_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_host_root_view.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_host_root_view.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/resize_area.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/resize_area.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_button.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_button.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_thumb.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_thumb.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/scrollbar/bitmap_scroll_bar.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/single_split_view.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/single_split_view.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/single_split_view_unittest.cc View 1 2 1 chunk +15 lines, -11 lines 0 comments Download
M ui/views/controls/slider.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/slider.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/slider_unittest.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M ui/views/controls/tabbed_pane/native_tabbed_pane_views.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M ui/views/controls/table/table_view_views.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 2 8 chunks +44 lines, -31 lines 0 comments Download
M ui/views/controls/tree/tree_view_views.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/events/event.h View 1 2 3 chunks +2 lines, -52 lines 0 comments Download
M ui/views/events/event.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M ui/views/events/event_aura.cc View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/view.h View 1 2 6 chunks +10 lines, -10 lines 0 comments Download
M ui/views/view.cc View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M ui/views/view_unittest.cc View 1 2 19 chunks +52 lines, -46 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 2 11 chunks +26 lines, -17 lines 0 comments Download
M ui/views/widget/widget.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
8 years, 4 months ago (2012-08-13 23:48:23 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-14 00:11:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/10832282/159
8 years, 4 months ago (2012-08-14 00:58:42 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 00:59:33 UTC) #4 
Presubmit check for 10832282-159 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ui/views/view.cc, line 1903, 82 chars \
  ui/views/view.cc, line 1925, 82 chars

Presubmit checks took 8.4s to calculate.

Powered by Google App Engine
This is Rietveld 408576698