Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 10832273: Fixed segmentation fault in ExtensionErrorUIDefault::ExtensionGlobalError::OnBubbleViewDidClose (Closed)

Created:
8 years, 4 months ago by qfel
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, Mattias Nissler (ping if slow), Jay Civelli, miket_OOO
Base URL:
http://git.chromium.org/chromium/src.git@blacklist
Visibility:
Public.

Description

Fixed segmentation fault in ExtensionErrorUIDefault::ExtensionGlobalError::OnBubbleViewDidClose BUG=142336 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/extension_error_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_error_ui_default.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
qfel
8 years, 4 months ago (2012-08-13 14:51:05 UTC) #1
Mihai Parparita -not on Chrome
(Mike is on vacation this week) LGTM +Jay, since I believe his http://crrev.com/146870 triggered this.
8 years, 4 months ago (2012-08-13 17:55:30 UTC) #2
Jay Civelli
LGTM Sorry for the breakage.
8 years, 4 months ago (2012-08-13 23:23:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qfel@google.com/10832273/1
8 years, 4 months ago (2012-08-14 08:00:55 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 10:19:37 UTC) #5
Change committed as 151451

Powered by Google App Engine
This is Rietveld 408576698