chrome/browser/extensions/extension_error_ui_default.cc - Issue 10832273: Fixed segmentation fault in ExtensionErrorUIDefault::ExtensionGlobalError::OnBubbleViewDidClose

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_error_ui_default.cc

Issue 10832273: Fixed segmentation fault in ExtensionErrorUIDefault::ExtensionGlobalError::OnBubbleViewDidClose (Closed) Base URL: http://git.chromium.org/chromium/src.git@blacklist

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_error_ui_default.cc

diff --git a/chrome/browser/extensions/extension_error_ui_default.cc b/chrome/browser/extensions/extension_error_ui_default.cc

index bc0fd68f7e1ab602dee89beed1c2cd5692b11883..704454ffc7d4ff689c9427f7487756c3b3116e7d 100644

--- a/chrome/browser/extensions/extension_error_ui_default.cc

+++ b/chrome/browser/extensions/extension_error_ui_default.cc

@@ -89,8 +89,9 @@ string16 ExtensionErrorUIDefault::ExtensionGlobalError::

void ExtensionErrorUIDefault::ExtensionGlobalError::

OnBubbleViewDidClose(Browser* browser) {

+ // This call deletes error_ui_ (and as a result of error_ui_ destruction,

+ // object pointed by this also gets deleted).

error_ui_->BubbleViewDidClose();

- error_ui_->browser_ = NULL;

}

void ExtensionErrorUIDefault::ExtensionGlobalError::

« no previous file with comments | « chrome/browser/extensions/extension_error_ui.cc ('k') | no next file » | no next file with comments »