Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Side by Side Diff: chrome/browser/extensions/extension_error_ui_default.cc

Issue 10832273: Fixed segmentation fault in ExtensionErrorUIDefault::ExtensionGlobalError::OnBubbleViewDidClose (Closed) Base URL: http://git.chromium.org/chromium/src.git@blacklist
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/extension_error_ui.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_error_ui_default.h" 5 #include "chrome/browser/extensions/extension_error_ui_default.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_finder.h" 10 #include "chrome/browser/ui/browser_finder.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 return error_ui_->GetBubbleViewAcceptButtonLabel(); 82 return error_ui_->GetBubbleViewAcceptButtonLabel();
83 } 83 }
84 84
85 string16 ExtensionErrorUIDefault::ExtensionGlobalError:: 85 string16 ExtensionErrorUIDefault::ExtensionGlobalError::
86 GetBubbleViewCancelButtonLabel() { 86 GetBubbleViewCancelButtonLabel() {
87 return error_ui_->GetBubbleViewCancelButtonLabel(); 87 return error_ui_->GetBubbleViewCancelButtonLabel();
88 } 88 }
89 89
90 void ExtensionErrorUIDefault::ExtensionGlobalError:: 90 void ExtensionErrorUIDefault::ExtensionGlobalError::
91 OnBubbleViewDidClose(Browser* browser) { 91 OnBubbleViewDidClose(Browser* browser) {
92 // This call deletes error_ui_ (and as a result of error_ui_ destruction,
93 // object pointed by this also gets deleted).
92 error_ui_->BubbleViewDidClose(); 94 error_ui_->BubbleViewDidClose();
93 error_ui_->browser_ = NULL;
94 } 95 }
95 96
96 void ExtensionErrorUIDefault::ExtensionGlobalError:: 97 void ExtensionErrorUIDefault::ExtensionGlobalError::
97 BubbleViewAcceptButtonPressed(Browser* browser) { 98 BubbleViewAcceptButtonPressed(Browser* browser) {
98 error_ui_->BubbleViewAcceptButtonPressed(); 99 error_ui_->BubbleViewAcceptButtonPressed();
99 } 100 }
100 101
101 void ExtensionErrorUIDefault::ExtensionGlobalError:: 102 void ExtensionErrorUIDefault::ExtensionGlobalError::
102 BubbleViewCancelButtonPressed(Browser* browser) { 103 BubbleViewCancelButtonPressed(Browser* browser) {
103 error_ui_->BubbleViewCancelButtonPressed(); 104 error_ui_->BubbleViewCancelButtonPressed();
104 } 105 }
105 106
106 // static 107 // static
107 ExtensionErrorUI* ExtensionErrorUI::Create( 108 ExtensionErrorUI* ExtensionErrorUI::Create(
108 ExtensionService* extension_service) { 109 ExtensionService* extension_service) {
109 return new ExtensionErrorUIDefault(extension_service); 110 return new ExtensionErrorUIDefault(extension_service);
110 } 111 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_error_ui.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698