Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: chrome/browser/extensions/extension_error_ui.cc

Issue 10832273: Fixed segmentation fault in ExtensionErrorUIDefault::ExtensionGlobalError::OnBubbleViewDidClose (Closed) Base URL: http://git.chromium.org/chromium/src.git@blacklist
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_error_ui_default.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_error_ui.h" 5 #include "chrome/browser/extensions/extension_error_ui.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/string16.h" 8 #include "base/string16.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/extensions/extension_service.h" 10 #include "chrome/browser/extensions/extension_service.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 79
80 string16 ExtensionErrorUI::GetBubbleViewAcceptButtonLabel() { 80 string16 ExtensionErrorUI::GetBubbleViewAcceptButtonLabel() {
81 return l10n_util::GetStringUTF16(IDS_EXTENSION_ALERT_ITEM_OK); 81 return l10n_util::GetStringUTF16(IDS_EXTENSION_ALERT_ITEM_OK);
82 } 82 }
83 83
84 string16 ExtensionErrorUI::GetBubbleViewCancelButtonLabel() { 84 string16 ExtensionErrorUI::GetBubbleViewCancelButtonLabel() {
85 return l10n_util::GetStringUTF16(IDS_EXTENSION_ALERT_ITEM_DETAILS); 85 return l10n_util::GetStringUTF16(IDS_EXTENSION_ALERT_ITEM_DETAILS);
86 } 86 }
87 87
88 void ExtensionErrorUI::BubbleViewDidClose() { 88 void ExtensionErrorUI::BubbleViewDidClose() {
89 // This call deletes ExtensionErrorUI object referenced by this.
89 extension_service_->HandleExtensionAlertClosed(); 90 extension_service_->HandleExtensionAlertClosed();
90 } 91 }
91 92
92 void ExtensionErrorUI::BubbleViewAcceptButtonPressed() { 93 void ExtensionErrorUI::BubbleViewAcceptButtonPressed() {
93 extension_service_->HandleExtensionAlertAccept(); 94 extension_service_->HandleExtensionAlertAccept();
94 } 95 }
95 96
96 void ExtensionErrorUI::BubbleViewCancelButtonPressed() { 97 void ExtensionErrorUI::BubbleViewCancelButtonPressed() {
97 extension_service_->HandleExtensionAlertDetails(); 98 extension_service_->HandleExtensionAlertDetails();
98 } 99 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_error_ui_default.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698