Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 10827341: Factoring out common constants (Closed)

Created:
8 years, 4 months ago by groby-ooo-7-16
Modified:
8 years, 4 months ago
Reviewers:
Greg Billock
CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org, tfarina
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed namespacing #

Patch Set 3 : Fix namespacing for Cocoa build #

Patch Set 4 : More cocoa namespacing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M chrome/browser/ui/cocoa/web_intent_sheet_controller.mm View 1 2 3 21 chunks +42 lines, -37 lines 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 3 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
8 years, 4 months ago (2012-08-14 23:56:25 UTC) #1
Greg Billock
On 2012/08/14 23:56:25, groby wrote: lgtm
8 years, 4 months ago (2012-08-15 06:41:25 UTC) #2
groby-ooo-7-16
Taken James off reviewers due to vacation.
8 years, 4 months ago (2012-08-15 21:59:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10827341/6001
8 years, 4 months ago (2012-08-15 21:59:36 UTC) #4
commit-bot: I haz the power
Try job failure for 10827341-6001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-15 22:50:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10827341/3004
8 years, 4 months ago (2012-08-16 01:14:24 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 04:32:35 UTC) #7
Change committed as 151850

Powered by Google App Engine
This is Rietveld 408576698