Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5815)

Unified Diff: chrome/browser/ui/views/web_intent_picker_views.cc

Issue 10827341: Factoring out common constants (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More cocoa namespacing. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/web_intent_picker_views.cc
diff --git a/chrome/browser/ui/views/web_intent_picker_views.cc b/chrome/browser/ui/views/web_intent_picker_views.cc
index 502dd3fe7ca56b27c2573094769e6473fe9f0474..3241395d466628bc88dc1c7455fc731aac1fdb93 100644
--- a/chrome/browser/ui/views/web_intent_picker_views.cc
+++ b/chrome/browser/ui/views/web_intent_picker_views.cc
@@ -60,15 +60,6 @@ using views::GridLayout;
namespace {
-// The space in pixels between the top-level groups and the dialog border.
-const int kContentAreaBorder = 12;
-
-// The minimum size to display the constrained dialog.
-const int kDialogMinWidth = 400;
-
-// The maximum width in pixels of a suggested extension's title link.
-const int kTitleLinkMaxWidth = 130;
-
// The color used to dim disabled elements.
const SkColor kHalfOpacityWhite = SkColorSetARGB(128, 255, 255, 255);
@@ -505,8 +496,9 @@ SuggestedExtensionsRowView::SuggestedExtensionsRowView(
icon_->SetImage(extension_->icon.ToImageSkia());
AddChildView(icon_);
- string16 elided_title = ui::ElideText(
- extension_->title, gfx::Font(), kTitleLinkMaxWidth, ui::ELIDE_AT_END);
+ string16 elided_title = ui::ElideText(extension_->title, gfx::Font(),
+ WebIntentPicker::kTitleLinkMaxWidth,
+ ui::ELIDE_AT_END);
title_link_ = new views::Link(elided_title);
title_link_->set_listener(this);
AddChildView(title_link_);
@@ -1094,7 +1086,7 @@ void WebIntentPickerViews::InitContents() {
views::GridLayout* grid_layout = new views::GridLayout(contents_);
contents_->SetLayoutManager(grid_layout);
- grid_layout->set_minimum_size(gfx::Size(kDialogMinWidth, 0));
+ grid_layout->set_minimum_size(gfx::Size(kWindowWidth, 0));
grid_layout->SetInsets(kContentAreaBorder, kContentAreaBorder,
kContentAreaBorder, kContentAreaBorder);
views::ColumnSet* header_cs = grid_layout->AddColumnSet(kHeaderRowColumnSet);
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698