Factoring out common constants

chrome/browser/ui/cocoa/web_intent_sheet_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/web_intent_sheet_controller.h"
 
 #include "base/memory/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/browser_list.h"
@@ skipping 17 matching lines @@
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/text/text_elider.h"
 #include "ui/gfx/image/image.h"
 
 using content::OpenURLParams;
 using content::Referrer;
 
 namespace {
 
-// The width of the window, in view coordinates. The height will be
-// determined by the content.
-const CGFloat kWindowWidth = 400;
-
-// The maximum width in view units of a suggested extension's title link.
-const int kTitleLinkMaxWidth = 130;
-
 // The width of a service button, in view coordinates.
 const CGFloat kServiceButtonWidth = 300;
 
-// Padding along on the X-axis between the window frame and content.
-const CGFloat kFramePadding = 10;
-
 // Spacing in between sections.
 const CGFloat kVerticalSpacing = 10;
 
 // Square size of the close button.
 const CGFloat kCloseButtonSize = 16;
 
 // Font size for picker header.
 const CGFloat kHeaderFontSize = 14.5;
 
 // Width of the text fields.
-const CGFloat kTextWidth = kWindowWidth -
-    (kFramePadding * 2 + kCloseButtonSize);
+const CGFloat kTextWidth = WebIntentPicker::kWindowWidth -
+    (WebIntentPicker::kContentAreaBorder * 2.0 + kCloseButtonSize);
 
 // Sets properties on the given |field| to act as title or description labels.
 void ConfigureTextFieldAsLabel(NSTextField* field) {
   [field setEditable:NO];
   [field setSelectable:YES];
   [field setDrawsBackground:NO];
   [field setBezeled:NO];
 }
 
 NSButton* CreateHyperlinkButton(NSString* title, const NSRect& frame) {
@@ skipping 116 matching lines @@
     (const WebIntentPickerModel::SuggestedExtension*)extension
               withIndex:(size_t)index
           forController:(WebIntentPickerSheetController*)controller {
   const CGFloat kMaxHeight = 34.0;
   const CGFloat kTitleX = 20.0;
   const CGFloat kMinAddButtonHeight = 24.0;
   const CGFloat kAddButtonX = 245;
   const CGFloat kAddButtonWidth = 128.0;
 
   // Build the main view
-  NSRect contentFrame = NSMakeRect(0, 0, kWindowWidth, kMaxHeight);
+  NSRect contentFrame = NSMakeRect(
+      0, 0, WebIntentPicker::kWindowWidth, kMaxHeight);
   if (self = [super initWithFrame:contentFrame]) {
     NSMutableArray* subviews = [NSMutableArray array];
 
     // Add the extension icon.
     NSImage* icon = extension->icon.ToNSImage();
     NSRect imageFrame = NSZeroRect;
 
     iconView_.reset(
         [[DimmableImageView alloc] initWithFrame:imageFrame]);
     [iconView_ setImage:icon];
     [iconView_ setImageFrameStyle:NSImageFrameNone];
     [iconView_ setEnabled:YES];
 
     imageFrame.size = [icon size];
     imageFrame.size.height = std::min(NSHeight(imageFrame), kMaxHeight);
     imageFrame.origin.y += (kMaxHeight - NSHeight(imageFrame)) / 2.0;
     [iconView_ setFrame:imageFrame];
     [subviews addObject:iconView_];
 
     // Add the extension title.
     NSRect frame = NSMakeRect(kTitleX, 0, 0, 0);
 
     const string16 elidedTitle = ui::ElideText(
-        extension->title, gfx::Font(), kTitleLinkMaxWidth, ui::ELIDE_AT_END);
+        extension->title, gfx::Font(), WebIntentPicker::kTitleLinkMaxWidth,
+        ui::ELIDE_AT_END);
     NSString* string = base::SysUTF16ToNSString(elidedTitle);
     cwsButton_.reset(CreateHyperlinkButton(string, frame));
     [cwsButton_ setAlignment:NSLeftTextAlignment];
     [cwsButton_ setTarget:controller];
     [cwsButton_ setAction:@selector(openExtensionLink:)];
     [cwsButton_ setTag:index];
     [cwsButton_ sizeToFit];
 
     frame = [cwsButton_ frame];
     frame.size.height = std::min([[cwsButton_ cell] cellSize].height,
                                  kMaxHeight);
     frame.origin.y = (kMaxHeight - NSHeight(frame)) / 2.0;
     [cwsButton_ setFrame:frame];
     [subviews addObject:cwsButton_];
 
     // Add the star rating
-    CGFloat offsetX = frame.origin.x + NSWidth(frame) + kFramePadding;
+    CGFloat offsetX = frame.origin.x + NSWidth(frame) +
+        WebIntentPicker::kContentAreaBorder;
     ratingsWidget_.reset(
         [SingleSuggestionView
             createStarWidgetWithRating:extension->average_rating]);
     frame = [ratingsWidget_ frame];
     frame.origin.y += (kMaxHeight - NSHeight(frame)) / 2.0;
     frame.origin.x = offsetX;
     [ratingsWidget_ setFrame: frame];
     [subviews addObject:ratingsWidget_];
 
     // Add an "add to chromium" button.
@@ skipping 126 matching lines @@
                           atOffset:offset];
   }
 
   [self updateSuggestionLabelForModel:model];
   offset += [self addStackedView:suggestionLabel_
                       toSubviews:subviews
                       atOffset:offset];
 
   offset += kYMargin;
 
-  NSRect contentFrame = NSMakeRect(kFramePadding, 0, kWindowWidth, offset);
+  NSRect contentFrame = NSMakeRect(WebIntentPicker::kContentAreaBorder, 0,
+                                   WebIntentPicker::kWindowWidth, offset);
   if(self =  [super initWithFrame:contentFrame])
     [self setSubviews: subviews];
 
   controller_ = controller;
   return self;
 }
 
 - (void)updateSuggestionLabelForModel:(WebIntentPickerModel*)model {
   DCHECK(suggestionLabel_.get());
   string16 labelText = model->GetSuggestionsLinkText();
@@ skipping 49 matching lines @@
   [subviews addObject:view];
 
   return NSHeight([view frame]);
 }
 @end
 
 @implementation WebIntentPickerSheetController;
 
 - (id)initWithPicker:(WebIntentPickerCocoa*)picker {
   // Use an arbitrary height because it will reflect the size of the content.
-  NSRect contentRect = NSMakeRect(0, 0, kWindowWidth, kVerticalSpacing);
+  NSRect contentRect = NSMakeRect(
+      0, 0, WebIntentPicker::kWindowWidth, kVerticalSpacing);
 
   // |window| is retained by the ConstrainedWindowMacDelegateCustomSheet when
   // the sheet is initialized.
   scoped_nsobject<NSWindow> window(
       [[NSWindow alloc] initWithContentRect:contentRect
                                   styleMask:NSTitledWindowMask
                                     backing:NSBackingStoreBuffered
                                       defer:YES]);
   if ((self = [super initWithWindow:window.get()])) {
     picker_ = picker;
@@ skipping 47 matching lines @@
   contents_ = tabContents;
 }
 
 - (void)setInlineDispositionFrameSize:(NSSize)inlineContentSize {
   DCHECK(contents_);
 
   NSView* webContentView = contents_->web_contents()->GetNativeView();
 
   // Compute container size to fit all elements, including padding.
   NSSize containerSize = inlineContentSize;
-  containerSize.height += [webContentView frame].origin.y + kFramePadding;
-  containerSize.width += 2 * kFramePadding;
+  containerSize.height +=
+      [webContentView frame].origin.y + WebIntentPicker::kContentAreaBorder;
+  containerSize.width += 2 * WebIntentPicker::kContentAreaBorder;
 
   // Ensure minimum container width.
-  containerSize.width = std::max(kWindowWidth, containerSize.width);
+  containerSize.width =
+      std::max(CGFloat(WebIntentPicker::kWindowWidth), containerSize.width);
 
   // Resize web contents.
   [webContentView setFrameSize:inlineContentSize];
 
   // Position close button.
   NSRect buttonFrame = [closeButton_ frame];
-  buttonFrame.origin.x = containerSize.width - kFramePadding - kCloseButtonSize;
+  buttonFrame.origin.x = containerSize.width -
+      WebIntentPicker::kContentAreaBorder - kCloseButtonSize;
   [closeButton_ setFrame:buttonFrame];
 
   [self setContainerSize:containerSize];
 }
 
 - (void)setContainerSize:(NSSize)containerSize {
   // Resize container views
   NSRect frame = NSMakeRect(0, 0, 0, 0);
   frame.size = containerSize;
   [[[self window] contentView] setFrame:frame];
@@ skipping 63 matching lines @@
   [view setFrameOrigin:frameOrigin];
   [subviews addObject:view];
 
   return NSHeight([view frame]);
 }
 
 // Adds a link to the Chrome Web Store, to obtain further intent handlers.
 // Returns the y position delta for the next offset.
 - (CGFloat)addCwsButtonToSubviews:(NSMutableArray*)subviews
                          atOffset:(CGFloat)offset {
-  NSRect frame = NSMakeRect(kFramePadding, offset, 100, 10);
+  NSRect frame =
+      NSMakeRect(WebIntentPicker::kContentAreaBorder, offset, 100, 10);
   NSString* string =
       l10n_util::GetNSStringWithFixup(IDS_FIND_MORE_INTENT_HANDLER_MESSAGE);
   scoped_nsobject<NSButton> button(CreateHyperlinkButton(string,frame));
   [button setTarget:self];
   [button setAction:@selector(showChromeWebStore:)];
   [subviews addObject:button.get()];
 
   // Call size-to-fit to fixup for the localized string.
   [GTMUILocalizerAndLayoutTweaker sizeToFitView:button.get()];
 
   return NSHeight([button frame]);
 }
 
 - (void)addCloseButtonToSubviews:(NSMutableArray*)subviews  {
   if (!closeButton_.get()) {
     NSRect buttonFrame = NSMakeRect(
-        kFramePadding + kTextWidth, kFramePadding,
+        WebIntentPicker::kContentAreaBorder + kTextWidth,
+        WebIntentPicker::kContentAreaBorder,
         kCloseButtonSize, kCloseButtonSize);
     closeButton_.reset(
         [[HoverCloseButton alloc] initWithFrame:buttonFrame]);
     [closeButton_ setTarget:self];
     [closeButton_ setAction:@selector(cancelOperation:)];
   }
   [subviews addObject:closeButton_];
 }
 
 // Adds a header (icon and explanatory text) to picker bubble.
@@ skipping 18 matching lines @@
   return NSHeight([actionTextField_ frame]);
 }
 
 - (CGFloat)addInlineHtmlToSubviews:(NSMutableArray*)subviews
                           atOffset:(CGFloat)offset {
   if (!contents_)
     return 0;
 
   // Determine a good size for the inline disposition window.
   gfx::Size size = WebIntentPicker::GetMinInlineDispositionSize();
-  NSRect frame = NSMakeRect(kFramePadding, offset, size.width(), size.height());
+  NSRect frame = NSMakeRect(
+      WebIntentPicker::kContentAreaBorder, offset, size.width(), size.height());
 
   [contents_->web_contents()->GetNativeView() setFrame:frame];
   [subviews addObject:contents_->web_contents()->GetNativeView()];
 
   return NSHeight(frame);
 }
 
 - (CGFloat)addAnotherServiceLinkToSubviews:(NSMutableArray*)subviews
                                   atOffset:(CGFloat)offset {
 
-  NSRect textFrame = NSMakeRect(kFramePadding, offset, kTextWidth, 1);
+  NSRect textFrame =
+      NSMakeRect(WebIntentPicker::kContentAreaBorder, offset, kTextWidth, 1);
   [inlineDispositionTitleField_ setFrame:textFrame];
   [subviews addObject:inlineDispositionTitleField_];
   [GTMUILocalizerAndLayoutTweaker sizeToFitView:inlineDispositionTitleField_];
   textFrame = [inlineDispositionTitleField_ frame];
 
   // Add link for "choose another service" if other suggestions are available
   // or if more than one (the current) service is installed.
   if (model_->GetInstalledServiceCount() > 1 ||
     model_->GetSuggestedExtensionCount()) {
     NSRect frame = NSMakeRect(
-        NSMaxX(textFrame) + kFramePadding, offset,
-        kTitleLinkMaxWidth, 1);
+        NSMaxX(textFrame) + WebIntentPicker::kContentAreaBorder, offset,
+        WebIntentPicker::kTitleLinkMaxWidth, 1);
     NSString* string = l10n_util::GetNSStringWithFixup(
         IDS_INTENT_PICKER_USE_ALTERNATE_SERVICE);
     scoped_nsobject<NSButton> button(CreateHyperlinkButton(string, frame));
     [[button cell] setControlSize:NSRegularControlSize];
     [button setTarget:self];
     [button setAction:@selector(chooseAnotherService:)];
     [subviews addObject:button];
 
     // Call size-to-fit to fixup for the localized string.
     [GTMUILocalizerAndLayoutTweaker sizeToFitView:button];
@@ skipping 12 matching lines @@
   return NSHeight(textFrame);
 }
 
 // Add a single button for a specific service
 - (CGFloat)addServiceButton:(NSString*)title
                  withImage:(NSImage*)image
                      index:(NSUInteger)index
                 toSubviews:(NSMutableArray*)subviews
                   atOffset:(CGFloat)offset {
   // Buttons are displayed centered.
-  CGFloat offsetX = (kWindowWidth - kServiceButtonWidth) / 2.0;
+  CGFloat offsetX = (WebIntentPicker::kWindowWidth - kServiceButtonWidth) / 2.0;
   NSRect frame = NSMakeRect(offsetX, offset, kServiceButtonWidth, 45);
   scoped_nsobject<NSButton> button([[NSButton alloc] initWithFrame:frame]);
 
   if (image) {
     [button setImage:image];
     [button setImagePosition:NSImageLeft];
   }
   [button setAlignment:NSLeftTextAlignment];
   [button setButtonType:NSMomentaryPushInButton];
   [button setBezelStyle:NSRegularSquareBezelStyle];
@@ skipping 11 matching lines @@
   frame = [button frame];
   frame.size.width = kServiceButtonWidth;
   [button setFrame:frame];
 
   return NSHeight([button frame]);
 }
 
 - (NSView*)createEmptyView {
   NSMutableArray* subviews = [NSMutableArray array];
 
-  NSRect titleFrame = NSMakeRect(kFramePadding, kFramePadding,
+  NSRect titleFrame = NSMakeRect(WebIntentPicker::kContentAreaBorder,
+                                 WebIntentPicker::kContentAreaBorder,
                                  kTextWidth, 1);
   scoped_nsobject<NSTextField> title(
       [[NSTextField alloc] initWithFrame:titleFrame]);
   ConfigureTextFieldAsLabel(title);
   [title setFont:[NSFont systemFontOfSize:kHeaderFontSize]];
   [title setStringValue:
       l10n_util::GetNSStringWithFixup(IDS_INTENT_PICKER_NO_SERVICES_TITLE)];
   titleFrame.size.height +=
       [GTMUILocalizerAndLayoutTweaker sizeToFitFixedWidthTextField:title];
 
   NSRect bodyFrame = titleFrame;
-  bodyFrame.origin.y += NSHeight(titleFrame) + kFramePadding;
+  bodyFrame.origin.y +=
+      NSHeight(titleFrame) + WebIntentPicker::kContentAreaBorder;
 
   scoped_nsobject<NSTextField> body(
       [[NSTextField alloc] initWithFrame:bodyFrame]);
   ConfigureTextFieldAsLabel(body);
   [body setStringValue:
       l10n_util::GetNSStringWithFixup(IDS_INTENT_PICKER_NO_SERVICES)];
   bodyFrame.size.height +=
       [GTMUILocalizerAndLayoutTweaker sizeToFitFixedWidthTextField:body];
   NSRect viewFrame = NSMakeRect(
       0,
-      kFramePadding,
-      std::max(NSWidth(bodyFrame), NSWidth(titleFrame)) + 2 * kFramePadding,
+      WebIntentPicker::kContentAreaBorder,
+      std::max(NSWidth(bodyFrame), NSWidth(titleFrame)) +
+          2 * WebIntentPicker::kContentAreaBorder,
       NSHeight(titleFrame) + NSHeight(bodyFrame) + kVerticalSpacing);
 
   titleFrame.origin.y = NSHeight(viewFrame) - NSHeight(titleFrame);
   bodyFrame.origin.y = 0;
 
   [title setFrame:titleFrame];
   [body setFrame: bodyFrame];
 
   [subviews addObject:title];
   [subviews addObject:body];
 
   NSView* view = [[NSView alloc] initWithFrame:viewFrame];
   [view setAutoresizingMask:NSViewMinYMargin ];
   [view setSubviews:subviews];
 
   return view;
 }
 
 - (void)performLayoutWithModel:(WebIntentPickerModel*)model {
   model_ = model;
 
   // |offset| is the Y position that should be drawn at next.
-  CGFloat offset = kFramePadding;
+  CGFloat offset = WebIntentPicker::kContentAreaBorder;
 
   // Keep the new subviews in an array that gets replaced at the end.
   NSMutableArray* subviews = [NSMutableArray array];
 
   if (isEmpty_) {
     scoped_nsobject<NSView> emptyView([self createEmptyView]);
     [subviews addObject:emptyView];
     offset += NSHeight([emptyView frame]);
   } else if (contents_) {
     offset += [self addAnotherServiceLinkToSubviews:subviews
                                            atOffset:offset];
-    offset += kFramePadding;
+    offset += WebIntentPicker::kContentAreaBorder;
     offset += [self addInlineHtmlToSubviews:subviews atOffset:offset];
   } else {
     offset += [self addHeaderToSubviews:subviews atOffset:offset];
 
     offset += kVerticalSpacing;
 
     if (model) {
       [intentButtons_ removeAllObjects];
 
       for (NSUInteger i = 0; i < model->GetInstalledServiceCount(); ++i) {
@@ skipping 19 matching lines @@
   }
   [self addCloseButtonToSubviews:subviews];
 
   // Add the bottom padding.
   offset += kVerticalSpacing;
 
   // Replace the window's content.
   [flipView_ setSubviews:subviews];
 
   // And resize to fit.
-  [self setContainerSize:NSMakeSize(kWindowWidth, offset)];
+  [self setContainerSize:NSMakeSize(WebIntentPicker::kWindowWidth, offset)];
 }
 
 - (void)setActionString:(NSString*)actionString {
   NSRect textFrame;
   if (!actionTextField_.get()) {
-    textFrame = NSMakeRect(kFramePadding, 0,
+    textFrame = NSMakeRect(WebIntentPicker::kContentAreaBorder, 0,
                            kTextWidth, 1);
 
     actionTextField_.reset([[NSTextField alloc] initWithFrame:textFrame]);
     ConfigureTextFieldAsLabel(actionTextField_);
     [actionTextField_ setFont:[NSFont systemFontOfSize:kHeaderFontSize]];
   } else {
     textFrame = [actionTextField_ frame];
   }
 
   [actionTextField_ setStringValue:actionString];
   textFrame.size.height +=
       [GTMUILocalizerAndLayoutTweaker sizeToFitFixedWidthTextField:
             actionTextField_];
   [actionTextField_ setFrame: textFrame];
 }
 
 - (void)setInlineDispositionTitle:(NSString*)title {
   NSFont* nsfont = [inlineDispositionTitleField_ font];
   gfx::Font font(
       base::SysNSStringToUTF8([nsfont fontName]), [nsfont pointSize]);
   NSString* elidedTitle = base::SysUTF16ToNSString(ui::ElideText(
         base::SysNSStringToUTF16(title),
-        font, kTitleLinkMaxWidth, ui::ELIDE_AT_END));
+        font, WebIntentPicker::kTitleLinkMaxWidth, ui::ELIDE_AT_END));
   [inlineDispositionTitleField_ setStringValue:elidedTitle];
 }
 
 - (void)stopThrobber {
   [closeButton_ setEnabled:YES];
   [self setIntentButtonsEnabled:YES];
   [suggestionView_ stopThrobber];
 }
 
 - (void)closeSheet {
   [NSApp endSheet:[self window]];
 }
 
 - (void)pendingAsyncCompleted {
   // Requests to both the WebIntentService and the Chrome Web Store have
   // completed. If there are any services, installed or suggested, there's
   // nothing to do.
   DCHECK(model_);
   isEmpty_ = !model_->GetInstalledServiceCount() &&
       !model_->GetSuggestedExtensionCount();
   [self performLayoutWithModel:model_];
 }
 
 @end  // WebIntentPickerSheetController