Factoring out common constants

chrome/browser/ui/gtk/web_intent_picker_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/web_intent_picker_gtk.h"
 
 #include <algorithm>
 
 #include "base/i18n/rtl.h"
 #include "base/utf_string_conversions.h"
@@ skipping 30 matching lines @@
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/text/text_elider.h"
 #include "ui/gfx/gtk_util.h"
 #include "ui/gfx/image/image.h"
 
 using content::WebContents;
 
 namespace {
 
-// The width in pixels of the area between the icon on the left and the close
-// button on the right.
-const int kMainContentWidth = 400;
-
 // The pixel size of the header label when using a non-native theme.
 const int kHeaderLabelPixelSize = 15;
 
 // The pixel size of the font of the main content of the dialog.
 const int kMainContentPixelSize = 13;
 
-// The maximum width in pixels of a suggested extension's title link.
-const int kTitleLinkMaxWidth = 130;
-
 // Indices of the extension row widgets.
 enum {
   kIconIndex,
   kTitleLinkIndex,
   kStarsIndex,
   kInstallButtonIndex,
 };
 
 GtkThemeService *GetThemeService(TabContents* tab_contents) {
   return GtkThemeService::GetFrom(tab_contents->profile());
@@ skipping 267 matching lines @@
   gtk_box_pack_start(GTK_BOX(sub_contents), hbox, TRUE, TRUE, 0);
   GtkThemeService* theme_service = GetThemeService(tab_contents_);
   GtkWidget* no_service_label = theme_service->BuildLabel(
       l10n_util::GetStringUTF8(IDS_INTENT_PICKER_NO_SERVICES).c_str(),
       ui::kGdkBlack);
   gtk_label_set_line_wrap(GTK_LABEL(no_service_label), TRUE);
   gtk_misc_set_alignment(GTK_MISC(no_service_label), 0, 0);
   // Set the label width to the size of |sub_contents|, which we don't have
   // access to yet, by calculating the main content width minus borders.
   gtk_util::SetLabelWidth(no_service_label,
-                          kMainContentWidth - 2 * ui::kContentAreaBorder);
+                          kWindowWidth - 2 * ui::kContentAreaBorder);
   gtk_box_pack_start(GTK_BOX(hbox), no_service_label, TRUE, TRUE, 0);
 
   gtk_widget_show_all(contents_);
 }
 
 GtkWidget* WebIntentPickerGtk::GetWidgetRoot() {
   return contents_;
 }
 
 GtkWidget* WebIntentPickerGtk::GetFocusWidget() {
@@ skipping 99 matching lines @@
 
 void WebIntentPickerGtk::InitContents() {
   GtkThemeService* theme_service = GetThemeService(tab_contents_);
 
   // Main contents vbox.
   if (!contents_) {
     contents_ = gtk_vbox_new(FALSE, 0);
     g_signal_connect(contents_, "destroy", G_CALLBACK(&OnDestroyThunk), this);
   }
 
-  gtk_widget_set_size_request(contents_, kMainContentWidth, -1);
+  gtk_widget_set_size_request(contents_, kWindowWidth, -1);
 
   AddCloseButton(contents_);
   GtkWidget* sub_contents = CreateSubContents(contents_);
   AddTitle(sub_contents);
 
   // Add separation between the installed services list and the app suggestions.
   GtkWidget* button_alignment = gtk_alignment_new(0.5, 0, 0, 0);
   gtk_alignment_set_padding(GTK_ALIGNMENT(button_alignment), 0,
                             kMainContentPixelSize * 2, 0, 0);
 
   // Vbox containing all service buttons.
   button_vbox_ = gtk_vbox_new(FALSE, ui::kControlSpacing);
   gtk_container_add(GTK_CONTAINER(button_alignment), button_vbox_);
   gtk_box_pack_start(GTK_BOX(sub_contents), button_alignment, TRUE, TRUE, 0);
 
   // Chrome Web Store label.
   cws_label_ = theme_service->BuildLabel(
       l10n_util::GetStringUTF8(IDS_INTENT_PICKER_GET_MORE_SERVICES).c_str(),
       ui::kGdkBlack);
   gtk_box_pack_start(GTK_BOX(sub_contents), cws_label_, TRUE, TRUE, 0);
   gtk_misc_set_alignment(GTK_MISC(cws_label_), 0, 0);
   gtk_widget_set_no_show_all(cws_label_, TRUE);
 
   // Set the label width to the size of |sub_contents|, which we don't have
   // access to yet, by calculating the main content width minus borders.
   gtk_util::SetLabelWidth(cws_label_,
-                          kMainContentWidth - 2 * ui::kContentAreaBorder);
+                          kWindowWidth - 2 * ui::kContentAreaBorder);
   gtk_util::ForceFontSizePixels(cws_label_, kMainContentPixelSize);
 
   // Suggested extensions vbox.
   extensions_vbox_ = gtk_vbox_new(FALSE, ui::kControlSpacing);
   GtkWidget* indent_extensions = gtk_alignment_new(0.0, 0.5, 1.0, 1.0);
   gtk_alignment_set_padding(GTK_ALIGNMENT(indent_extensions), 0, 0,
                             ui::kGroupIndent, ui::kGroupIndent);
   gtk_container_add(GTK_CONTAINER(indent_extensions), extensions_vbox_);
   gtk_widget_set_no_show_all(indent_extensions, TRUE);
   gtk_box_pack_start(GTK_BOX(sub_contents), indent_extensions, TRUE, TRUE, 0);
@@ skipping 198 matching lines @@
   return alignment;
 }
 
 void WebIntentPickerGtk::RemoveThrobber() {
   GtkWidget* alignment = gtk_widget_get_parent(throbber_->widget());
   DCHECK(alignment);
   gtk_container_remove(GTK_CONTAINER(alignment), throbber_->widget());
   gtk_widget_destroy(alignment);
   throbber_->Stop();
 }