Issue 10825437: net: Fix more clang warnings about missing virtual and OVERRIDE annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825437: net: Fix more clang warnings about missing virtual and OVERRIDE annotations. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

net: Fix more clang warnings about missing virtual and OVERRIDE annotations. BUG=115047 R=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152296

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -35 lines)			Patch
M	net/base/dns_reloader.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/net_util.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/base/network_change_notifier.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/entry_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/disk_cache/file_posix.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/disk_cache/sparse_control.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/dns/dns_config_service_posix.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/ocsp/nss_ocsp.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	net/proxy/proxy_service.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/socket/client_socket_factory.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_http_job.cc	View	1 chunk	+9 lines, -9 lines	0 comments	Download

Total messages: 4 (0 generated)

tfarina

Hi Will, please, take a look. When you approve this, can you put in the ...

8 years, 4 months ago (2012-08-18 21:54:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10825437/7001

8 years, 4 months ago (2012-08-19 16:37:46 UTC) #3

Change committed as 152296