net/disk_cache/entry_impl.cc - Issue 10825437: net: Fix more clang warnings about missing virtual and OVERRIDE annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/entry_impl.cc

Issue 10825437: net: Fix more clang warnings about missing virtual and OVERRIDE annotations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/disk_cache/entry_impl.cc

diff --git a/net/disk_cache/entry_impl.cc b/net/disk_cache/entry_impl.cc

index 6155aa1679f2d3f4e1fc5913410f80e98b186d93..e4eb75a43358d4e625006d37e6753a190d638aeb 100644

--- a/net/disk_cache/entry_impl.cc

+++ b/net/disk_cache/entry_impl.cc

@@ -40,9 +40,9 @@ class SyncCallback: public disk_cache::FileIOCallback {

entry->AddRef();

entry->IncrementIoCount();

}

- ~SyncCallback() {}

+ virtual ~SyncCallback() {}

- virtual void OnFileIOComplete(int bytes_copied);

+ virtual void OnFileIOComplete(int bytes_copied) OVERRIDE;

void Discard();

private:

« no previous file with comments | « net/base/network_change_notifier.cc ('k') | net/disk_cache/file_posix.cc » ('j') | no next file with comments »