Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: net/url_request/url_request_http_job.cc

Issue 10825437: net: Fix more clang warnings about missing virtual and OVERRIDE annotations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_http_job.h" 5 #include "net/url_request/url_request_http_job.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 static const char kAvailDictionaryHeader[] = "Avail-Dictionary"; 48 static const char kAvailDictionaryHeader[] = "Avail-Dictionary";
49 49
50 namespace net { 50 namespace net {
51 51
52 class URLRequestHttpJob::HttpFilterContext : public FilterContext { 52 class URLRequestHttpJob::HttpFilterContext : public FilterContext {
53 public: 53 public:
54 explicit HttpFilterContext(URLRequestHttpJob* job); 54 explicit HttpFilterContext(URLRequestHttpJob* job);
55 virtual ~HttpFilterContext(); 55 virtual ~HttpFilterContext();
56 56
57 // FilterContext implementation. 57 // FilterContext implementation.
58 virtual bool GetMimeType(std::string* mime_type) const; 58 virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
59 virtual bool GetURL(GURL* gurl) const; 59 virtual bool GetURL(GURL* gurl) const OVERRIDE;
60 virtual base::Time GetRequestTime() const; 60 virtual base::Time GetRequestTime() const OVERRIDE;
61 virtual bool IsCachedContent() const; 61 virtual bool IsCachedContent() const OVERRIDE;
62 virtual bool IsDownload() const; 62 virtual bool IsDownload() const OVERRIDE;
63 virtual bool IsSdchResponse() const; 63 virtual bool IsSdchResponse() const OVERRIDE;
64 virtual int64 GetByteReadCount() const; 64 virtual int64 GetByteReadCount() const OVERRIDE;
65 virtual int GetResponseCode() const; 65 virtual int GetResponseCode() const OVERRIDE;
66 virtual void RecordPacketStats(StatisticSelector statistic) const; 66 virtual void RecordPacketStats(StatisticSelector statistic) const OVERRIDE;
67 67
68 // Method to allow us to reset filter context for a response that should have 68 // Method to allow us to reset filter context for a response that should have
69 // been SDCH encoded when there is an update due to an explicit HTTP header. 69 // been SDCH encoded when there is an update due to an explicit HTTP header.
70 void ResetSdchResponseToFalse(); 70 void ResetSdchResponseToFalse();
71 71
72 private: 72 private:
73 URLRequestHttpJob* job_; 73 URLRequestHttpJob* job_;
74 74
75 DISALLOW_COPY_AND_ASSIGN(HttpFilterContext); 75 DISALLOW_COPY_AND_ASSIGN(HttpFilterContext);
76 }; 76 };
(...skipping 1390 matching lines...) Expand 10 before | Expand all | Expand 10 after
1467 1467
1468 void URLRequestHttpJob::NotifyURLRequestDestroyed() { 1468 void URLRequestHttpJob::NotifyURLRequestDestroyed() {
1469 awaiting_callback_ = false; 1469 awaiting_callback_ = false;
1470 } 1470 }
1471 1471
1472 void URLRequestHttpJob::OnDetachRequest() { 1472 void URLRequestHttpJob::OnDetachRequest() {
1473 http_transaction_delegate_->OnDetachRequest(); 1473 http_transaction_delegate_->OnDetachRequest();
1474 } 1474 }
1475 1475
1476 } // namespace net 1476 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698