net/base/dns_reloader.cc - Issue 10825437: net: Fix more clang warnings about missing virtual and OVERRIDE annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/dns_reloader.cc

Issue 10825437: net: Fix more clang warnings about missing virtual and OVERRIDE annotations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/dns_reloader.cc

diff --git a/net/base/dns_reloader.cc b/net/base/dns_reloader.cc

index f0a57e6b52e691971000f6c500ba7e77ac527160..f90c4648f4c65758f9cfecdea1a3f596b9941b27 100644

--- a/net/base/dns_reloader.cc

+++ b/net/base/dns_reloader.cc

@@ -84,7 +84,7 @@ class DnsReloader : public net::NetworkChangeNotifier::DNSObserver {

net::NetworkChangeNotifier::AddDNSObserver(this);

}

- ~DnsReloader() {

+ virtual ~DnsReloader() {

NOTREACHED(); // LeakyLazyInstance is not destructed.

}

« no previous file with comments | « no previous file | net/base/net_util.cc » ('j') | no next file with comments »