Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10824402: Convert ui::MenuModel to use gfx::Image instead of ImageSkia. (Closed)

Created:
8 years, 4 months ago by Robert Sesek
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Convert ui::MenuModel to use gfx::Image instead of ImageSkia. BUG=58030 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152767

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase again #

Patch Set 5 : Another day, another rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -120 lines) Patch
M chrome/browser/background/background_mode_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/menu_controller.mm View 3 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_controller_unittest.mm View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_sub_menu_model_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/menu_gtk.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/menu_gtk.cc View 1 2 3 6 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/toolbar/action_box_menu_model.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/menu_model_adapter_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M ui/base/models/menu_model.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/models/simple_menu_model.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/base/models/simple_menu_model.cc View 14 chunks +18 lines, -18 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/native_menu_win.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M ui/views/view_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Robert Sesek
8 years, 4 months ago (2012-08-21 19:01:39 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-21 20:37:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10824402/3003
8 years, 4 months ago (2012-08-21 20:39:24 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/gtk/menu_gtk.cc: While running patch -p1 --forward --force; patching file chrome/browser/ui/gtk/menu_gtk.cc ...
8 years, 4 months ago (2012-08-21 20:39:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10824402/11001
8 years, 4 months ago (2012-08-21 20:43:57 UTC) #5
commit-bot: I haz the power
Try job failure for 10824402-11001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-21 21:17:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10824402/11002
8 years, 4 months ago (2012-08-21 21:34:54 UTC) #7
commit-bot: I haz the power
Try job failure for 10824402-11002 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-21 23:11:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10824402/11002
8 years, 4 months ago (2012-08-21 23:19:34 UTC) #9
commit-bot: I haz the power
Try job failure for 10824402-11002 (retry) on win_rel for steps "browser_tests, unit_tests". It's a second ...
8 years, 4 months ago (2012-08-22 01:42:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10824402/11002
8 years, 4 months ago (2012-08-22 12:21:40 UTC) #11
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chromeos/status/network_menu.cc: While running patch -p1 --forward --force; patching file chrome/browser/chromeos/status/network_menu.cc ...
8 years, 4 months ago (2012-08-22 12:21:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10824402/22001
8 years, 4 months ago (2012-08-22 12:43:28 UTC) #13
commit-bot: I haz the power
8 years, 4 months ago (2012-08-22 14:08:20 UTC) #14 
Try job failure for 10824402-22001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698