Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: ui/views/controls/menu/menu_item_view.cc

Issue 10824402: Convert ui::MenuModel to use gfx::Image instead of ImageSkia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another day, another rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/models/simple_menu_model.cc ('k') | ui/views/controls/menu/menu_model_adapter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_item_view.cc
diff --git a/ui/views/controls/menu/menu_item_view.cc b/ui/views/controls/menu/menu_item_view.cc
index c85146ac69866ca2b8e5aee11171f95b3c4ca464..cae038242e84eafeff0efcefedfb9b91613f153f 100644
--- a/ui/views/controls/menu/menu_item_view.cc
+++ b/ui/views/controls/menu/menu_item_view.cc
@@ -12,6 +12,7 @@
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/models/menu_model.h"
#include "ui/gfx/canvas.h"
+#include "ui/gfx/image/image.h"
#include "ui/views/controls/button/menu_button.h"
#include "ui/views/controls/image_view.h"
#include "ui/views/controls/menu/menu_config.h"
@@ -286,7 +287,7 @@ MenuItemView* MenuItemView::AppendMenuItemWithIcon(int item_id,
MenuItemView* MenuItemView::AppendMenuItemFromModel(ui::MenuModel* model,
int index,
int id) {
- gfx::ImageSkia icon;
+ gfx::Image icon;
string16 label;
MenuItemView::Type type;
ui::MenuModel::ItemType menu_type = model->GetTypeAt(index);
@@ -318,7 +319,10 @@ MenuItemView* MenuItemView::AppendMenuItemFromModel(ui::MenuModel* model,
break;
}
- return AppendMenuItemImpl(id, label, icon, type);
+ return AppendMenuItemImpl(id,
+ label,
+ icon.IsEmpty() ? gfx::ImageSkia() : *icon.ToImageSkia(),
+ type);
}
MenuItemView* MenuItemView::AppendMenuItemImpl(int item_id,
« no previous file with comments | « ui/base/models/simple_menu_model.cc ('k') | ui/views/controls/menu/menu_model_adapter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698