Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 10824402: Convert ui::MenuModel to use gfx::Image instead of ImageSkia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another day, another rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/wrench_menu_model.h" 5 #include "chrome/browser/ui/toolbar/wrench_menu_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 } 292 }
293 return l10n_util::GetStringUTF16(string_id); 293 return l10n_util::GetStringUTF16(string_id);
294 } 294 }
295 default: 295 default:
296 NOTREACHED(); 296 NOTREACHED();
297 return string16(); 297 return string16();
298 } 298 }
299 } 299 }
300 300
301 bool WrenchMenuModel::GetIconForCommandId(int command_id, 301 bool WrenchMenuModel::GetIconForCommandId(int command_id,
302 gfx::ImageSkia* icon) const { 302 gfx::Image* icon) const {
303 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 303 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
304 switch (command_id) { 304 switch (command_id) {
305 case IDC_UPGRADE_DIALOG: { 305 case IDC_UPGRADE_DIALOG: {
306 if (UpgradeDetector::GetInstance()->notify_upgrade()) { 306 if (UpgradeDetector::GetInstance()->notify_upgrade()) {
307 *icon = *rb.GetNativeImageNamed( 307 *icon = rb.GetNativeImageNamed(
308 UpgradeDetector::GetInstance()->GetIconResourceID( 308 UpgradeDetector::GetInstance()->GetIconResourceID(
309 UpgradeDetector::UPGRADE_ICON_TYPE_MENU_ICON)).ToImageSkia(); 309 UpgradeDetector::UPGRADE_ICON_TYPE_MENU_ICON));
310 return true; 310 return true;
311 } 311 }
312 return false; 312 return false;
313 } 313 }
314 case IDC_SHOW_SYNC_SETUP: { 314 case IDC_SHOW_SYNC_SETUP: {
315 ProfileSyncService* service = 315 ProfileSyncService* service =
316 ProfileSyncServiceFactory::GetInstance()->GetForProfile( 316 ProfileSyncServiceFactory::GetInstance()->GetForProfile(
317 browser_->profile()->GetOriginalProfile()); 317 browser_->profile()->GetOriginalProfile());
318 SyncGlobalError* error = service->sync_global_error(); 318 SyncGlobalError* error = service->sync_global_error();
319 if (error && error->HasCustomizedSyncMenuItem()) { 319 if (error && error->HasCustomizedSyncMenuItem()) {
320 int icon_id = error->MenuItemIconResourceID(); 320 int icon_id = error->MenuItemIconResourceID();
321 if (icon_id) { 321 if (icon_id) {
322 *icon = *rb.GetNativeImageNamed(icon_id).ToImageSkia(); 322 *icon = rb.GetNativeImageNamed(icon_id);
323 return true; 323 return true;
324 } 324 }
325 } 325 }
326 return false; 326 return false;
327 } 327 }
328 default: 328 default:
329 break; 329 break;
330 } 330 }
331 return false; 331 return false;
332 } 332 }
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 IDS_VIEW_BACKGROUND_PAGES, num_background_pages)); 516 IDS_VIEW_BACKGROUND_PAGES, num_background_pages));
517 } 517 }
518 518
519 if (browser_defaults::kShowUpgradeMenuItem) 519 if (browser_defaults::kShowUpgradeMenuItem)
520 AddItem(IDC_UPGRADE_DIALOG, l10n_util::GetStringUTF16(IDS_UPDATE_NOW)); 520 AddItem(IDC_UPGRADE_DIALOG, l10n_util::GetStringUTF16(IDS_UPDATE_NOW));
521 AddItem(IDC_VIEW_INCOMPATIBILITIES, l10n_util::GetStringUTF16( 521 AddItem(IDC_VIEW_INCOMPATIBILITIES, l10n_util::GetStringUTF16(
522 IDS_VIEW_INCOMPATIBILITIES)); 522 IDS_VIEW_INCOMPATIBILITIES));
523 523
524 #if defined(OS_WIN) 524 #if defined(OS_WIN)
525 SetIcon(GetIndexOfCommandId(IDC_VIEW_INCOMPATIBILITIES), 525 SetIcon(GetIndexOfCommandId(IDC_VIEW_INCOMPATIBILITIES),
526 *ui::ResourceBundle::GetSharedInstance(). 526 ui::ResourceBundle::GetSharedInstance().
527 GetImageSkiaNamed(IDR_CONFLICT_MENU)); 527 GetNativeImageNamed(IDR_CONFLICT_MENU));
528 #endif 528 #endif
529 529
530 if (!is_touch_menu) { 530 if (!is_touch_menu) {
531 AddItemWithStringId(IDC_HELP_PAGE_VIA_MENU, IDS_HELP_PAGE); 531 AddItemWithStringId(IDC_HELP_PAGE_VIA_MENU, IDS_HELP_PAGE);
532 532
533 if (browser_defaults::kShowHelpMenuItemIcon) { 533 if (browser_defaults::kShowHelpMenuItemIcon) {
534 ui::ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 534 ui::ResourceBundle& rb = ResourceBundle::GetSharedInstance();
535 SetIcon(GetIndexOfCommandId(IDC_HELP_PAGE_VIA_MENU), 535 SetIcon(GetIndexOfCommandId(IDC_HELP_PAGE_VIA_MENU),
536 *rb.GetImageSkiaNamed(IDR_HELP_MENU)); 536 rb.GetNativeImageNamed(IDR_HELP_MENU));
537 } 537 }
538 } 538 }
539 539
540 if (browser_defaults::kShowFeedbackMenuItem) 540 if (browser_defaults::kShowFeedbackMenuItem)
541 AddItemWithStringId(IDC_FEEDBACK, IDS_FEEDBACK); 541 AddItemWithStringId(IDC_FEEDBACK, IDS_FEEDBACK);
542 542
543 AddGlobalErrorMenuItems(); 543 AddGlobalErrorMenuItems();
544 544
545 if (is_touch_menu) { 545 if (is_touch_menu) {
546 AddSubMenuWithStringId(IDC_ZOOM_MENU, IDS_MORE_TOOLS_MENU, 546 AddSubMenuWithStringId(IDC_ZOOM_MENU, IDS_MORE_TOOLS_MENU,
(...skipping 19 matching lines...) Expand all
566 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 566 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
567 const GlobalErrorService::GlobalErrorList& errors = 567 const GlobalErrorService::GlobalErrorList& errors =
568 GlobalErrorServiceFactory::GetForProfile(browser_->profile())->errors(); 568 GlobalErrorServiceFactory::GetForProfile(browser_->profile())->errors();
569 for (GlobalErrorService::GlobalErrorList::const_iterator 569 for (GlobalErrorService::GlobalErrorList::const_iterator
570 it = errors.begin(); it != errors.end(); ++it) { 570 it = errors.begin(); it != errors.end(); ++it) {
571 GlobalError* error = *it; 571 GlobalError* error = *it;
572 if (error->HasMenuItem()) { 572 if (error->HasMenuItem()) {
573 AddItem(error->MenuItemCommandID(), error->MenuItemLabel()); 573 AddItem(error->MenuItemCommandID(), error->MenuItemLabel());
574 int icon_id = error->MenuItemIconResourceID(); 574 int icon_id = error->MenuItemIconResourceID();
575 if (icon_id) { 575 if (icon_id) {
576 gfx::Image& image = rb.GetImageNamed(icon_id); 576 const gfx::Image& image = rb.GetNativeImageNamed(icon_id);
577 SetIcon(GetIndexOfCommandId(error->MenuItemCommandID()), 577 SetIcon(GetIndexOfCommandId(error->MenuItemCommandID()),
578 *image.ToImageSkia()); 578 image);
579 } 579 }
580 } 580 }
581 } 581 }
582 } 582 }
583 583
584 void WrenchMenuModel::CreateCutCopyPasteMenu(bool append_final_separator) { 584 void WrenchMenuModel::CreateCutCopyPasteMenu(bool append_final_separator) {
585 AddSeparator(); 585 AddSeparator();
586 586
587 #if defined(OS_POSIX) && !defined(TOOLKIT_VIEWS) 587 #if defined(OS_POSIX) && !defined(TOOLKIT_VIEWS)
588 // WARNING: Mac does not use the ButtonMenuItemModel, but instead defines the 588 // WARNING: Mac does not use the ButtonMenuItemModel, but instead defines the
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 zoom_label_ = l10n_util::GetStringFUTF16( 647 zoom_label_ = l10n_util::GetStringFUTF16(
648 IDS_ZOOM_PERCENT, base::IntToString16(zoom_percent)); 648 IDS_ZOOM_PERCENT, base::IntToString16(zoom_percent));
649 } 649 }
650 650
651 string16 WrenchMenuModel::GetSyncMenuLabel() const { 651 string16 WrenchMenuModel::GetSyncMenuLabel() const {
652 Profile* profile = browser_->profile()->GetOriginalProfile(); 652 Profile* profile = browser_->profile()->GetOriginalProfile();
653 return sync_ui_util::GetSyncMenuLabel( 653 return sync_ui_util::GetSyncMenuLabel(
654 ProfileSyncServiceFactory::GetForProfile(profile), 654 ProfileSyncServiceFactory::GetForProfile(profile),
655 *SigninManagerFactory::GetForProfile(profile)); 655 *SigninManagerFactory::GetForProfile(profile));
656 } 656 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.h ('k') | chrome/browser/ui/views/menu_model_adapter_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698