Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/browser/ui/gtk/menu_gtk.cc

Issue 10824402: Convert ui::MenuModel to use gfx::Image instead of ImageSkia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another day, another rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/menu_gtk.h ('k') | chrome/browser/ui/toolbar/action_box_menu_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/menu_gtk.cc
diff --git a/chrome/browser/ui/gtk/menu_gtk.cc b/chrome/browser/ui/gtk/menu_gtk.cc
index 32790f237e195860115e1e3d16944d76329f400f..ffa90019f5bc0fda9c4638c6a4d7952fe2efcbc1 100644
--- a/chrome/browser/ui/gtk/menu_gtk.cc
+++ b/chrome/browser/ui/gtk/menu_gtk.cc
@@ -23,6 +23,7 @@
#include "ui/base/models/button_menu_item_model.h"
#include "ui/base/models/menu_model.h"
#include "ui/gfx/gtk_util.h"
+#include "ui/gfx/image/image.h"
#include "webkit/glue/window_open_disposition.h"
bool MenuGtk::block_activation_ = false;
@@ -326,7 +327,7 @@ GtkWidget* MenuGtk::AppendMenuItemWithLabel(int command_id,
GtkWidget* MenuGtk::AppendMenuItemWithIcon(int command_id,
const std::string& label,
- const SkBitmap& icon) {
+ const gfx::Image& icon) {
std::string converted_label = ui::ConvertAcceleratorsFromWindowsStyle(label);
GtkWidget* menu_item = BuildMenuItemWithImage(converted_label, icon);
return AppendMenuItem(command_id, menu_item);
@@ -426,11 +427,9 @@ GtkWidget* MenuGtk::BuildMenuItemWithImage(const std::string& label,
}
GtkWidget* MenuGtk::BuildMenuItemWithImage(const std::string& label,
- const SkBitmap& icon) {
- GdkPixbuf* pixbuf = gfx::GdkPixbufFromSkBitmap(icon);
+ const gfx::Image& icon) {
GtkWidget* menu_item = BuildMenuItemWithImage(label,
- gtk_image_new_from_pixbuf(pixbuf));
- g_object_unref(pixbuf);
+ gtk_image_new_from_pixbuf(icon.ToGdkPixbuf()));
return menu_item;
}
@@ -451,7 +450,7 @@ void MenuGtk::BuildSubmenuFromModel(ui::MenuModel* model, GtkWidget* menu) {
std::map<int, GtkWidget*> radio_groups;
GtkWidget* menu_item = NULL;
for (int i = 0; i < model->GetItemCount(); ++i) {
- gfx::ImageSkia icon;
+ gfx::Image icon;
std::string label = ui::ConvertAcceleratorsFromWindowsStyle(
UTF16ToUTF8(model->GetLabelAt(i)));
bool connect_to_activate = true;
@@ -490,7 +489,7 @@ void MenuGtk::BuildSubmenuFromModel(ui::MenuModel* model, GtkWidget* menu) {
case ui::MenuModel::TYPE_COMMAND: {
int command_id = model->GetCommandIdAt(i);
if (model->GetIconAt(i, &icon))
- menu_item = BuildMenuItemWithImage(label, *icon.bitmap());
+ menu_item = BuildMenuItemWithImage(label, icon);
else
menu_item = BuildMenuItemWithLabel(label, command_id);
if (delegate_ && delegate_->AlwaysShowIconForCmd(command_id) &&
@@ -885,12 +884,11 @@ void MenuGtk::SetMenuItemInfo(GtkWidget* widget, gpointer userdata) {
gtk_menu_item_set_label(GTK_MENU_ITEM(widget), label.c_str());
if (GTK_IS_IMAGE_MENU_ITEM(widget)) {
- gfx::ImageSkia icon;
+ gfx::Image icon;
if (model->GetIconAt(id, &icon)) {
- GdkPixbuf* pixbuf = gfx::GdkPixbufFromSkBitmap(*icon.bitmap());
gtk_image_menu_item_set_image(GTK_IMAGE_MENU_ITEM(widget),
- gtk_image_new_from_pixbuf(pixbuf));
- g_object_unref(pixbuf);
+ gtk_image_new_from_pixbuf(
+ icon.ToGdkPixbuf()));
} else {
gtk_image_menu_item_set_image(GTK_IMAGE_MENU_ITEM(widget), NULL);
}
« no previous file with comments | « chrome/browser/ui/gtk/menu_gtk.h ('k') | chrome/browser/ui/toolbar/action_box_menu_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698