|
[Sync] Avoid unregistering object IDs on shutdown
Add RegisterHandler() and UnregisterHandler(), which should be called before and after calls to UpdateRegisteredIds(). Use UnregisterHandler() on
shutdown instead of UpdateRegisteredIds(_, ObjectIdSet()).
Make SyncNotifierHelper non-thread-safe. Fix test breakages that this revealed. Also add GetAllRegisteredIds() instead of making it the return value of UpdateRegisteredIds().
Propagate UpdateRegisteredIds()/RegisterHandler()/UnregisterHandler() all
the way up to ProfileSyncService.
Make FakeSyncManager be created on the sync thread.
Clean up SyncBackendHost startup/shutdown behavior a bit.
BUG= 140325
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150990
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151107
Total comments: 2
Total comments: 4
Total comments: 92
Total comments: 6
Total comments: 32
Total comments: 33
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+1072 lines, -514 lines) |
Patch |
|
M |
chrome/browser/sync/glue/bridged_sync_notifier.h
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/bridged_sync_notifier.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+15 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
4 chunks |
+29 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/chrome_sync_notification_bridge.h
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/chrome_sync_notification_bridge.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
9 chunks |
+62 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
4 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/sync_backend_host.h
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/sync_backend_host.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
12 chunks |
+58 lines, -28 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/sync_backend_host_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
10 chunks |
+80 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
3 chunks |
+48 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
4 chunks |
+19 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
|
3 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
sync/internal_api/public/sync_manager.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+9 lines, -2 lines |
0 comments
|
Download
|
|
M |
sync/internal_api/public/test/fake_sync_manager.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
5 chunks |
+24 lines, -19 lines |
0 comments
|
Download
|
|
M |
sync/internal_api/sync_manager_impl.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
sync/internal_api/sync_manager_impl.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
3 chunks |
+25 lines, -5 lines |
0 comments
|
Download
|
|
M |
sync/internal_api/sync_manager_impl_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
4 chunks |
+19 lines, -2 lines |
0 comments
|
Download
|
|
M |
sync/internal_api/test/fake_sync_manager.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
5 chunks |
+39 lines, -17 lines |
0 comments
|
Download
|
|
M |
sync/notifier/invalidation_notifier.h
|
View
|
1
2
3
4
5
6
7
8
9
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
sync/notifier/invalidation_notifier.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
2 chunks |
+15 lines, -6 lines |
0 comments
|
Download
|
|
M |
sync/notifier/invalidation_notifier_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
6 chunks |
+13 lines, -12 lines |
0 comments
|
Download
|
|
M |
sync/notifier/non_blocking_invalidation_notifier.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
4 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
sync/notifier/non_blocking_invalidation_notifier.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
4 chunks |
+23 lines, -9 lines |
0 comments
|
Download
|
|
M |
sync/notifier/non_blocking_invalidation_notifier_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
3 chunks |
+8 lines, -5 lines |
0 comments
|
Download
|
|
M |
sync/notifier/p2p_notifier.h
|
View
|
1
2
3
4
5
6
7
8
9
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
sync/notifier/p2p_notifier.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
5 chunks |
+18 lines, -5 lines |
0 comments
|
Download
|
|
M |
sync/notifier/p2p_notifier_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
4 chunks |
+15 lines, -14 lines |
0 comments
|
Download
|
|
M |
sync/notifier/sync_notifier.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+37 lines, -3 lines |
0 comments
|
Download
|
|
M |
sync/notifier/sync_notifier_factory_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
sync/notifier/sync_notifier_helper.h
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+0 lines, -55 lines |
0 comments
|
Download
|
|
M |
sync/notifier/sync_notifier_helper.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+0 lines, -95 lines |
0 comments
|
Download
|
|
M |
sync/notifier/sync_notifier_helper_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+0 lines, -156 lines |
0 comments
|
Download
|
|
A |
sync/notifier/sync_notifier_registrar.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+82 lines, -0 lines |
0 comments
|
Download
|
|
A |
sync/notifier/sync_notifier_registrar.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+129 lines, -0 lines |
0 comments
|
Download
|
|
A |
sync/notifier/sync_notifier_registrar_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+248 lines, -0 lines |
0 comments
|
Download
|
|
M |
sync/sync.gyp
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
sync/tools/sync_listen_notifications.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
Total messages: 31 (0 generated)
|