Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Side by Side Diff: sync/tools/sync_listen_notifications.cc

Issue 10824161: [Sync] Avoid unregistering object IDs on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Work around brittle unit test Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/sync.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <cstddef>
5 #include <cstdio> 6 #include <cstdio>
6 #include <string> 7 #include <string>
7 8
8 #include "base/at_exit.h" 9 #include "base/at_exit.h"
9 #include "base/base64.h" 10 #include "base/base64.h"
10 #include "base/command_line.h" 11 #include "base/command_line.h"
11 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
12 #include "base/logging.h" 13 #include "base/logging.h"
13 #include "base/memory/ref_counted.h" 14 #include "base/memory/ref_counted.h"
14 #include "base/memory/scoped_ptr.h" 15 #include "base/memory/scoped_ptr.h"
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 SyncNotifierFactory sync_notifier_factory( 236 SyncNotifierFactory sync_notifier_factory(
236 notifier_options, kClientInfo, 237 notifier_options, kClientInfo,
237 null_invalidation_state_tracker.AsWeakPtr()); 238 null_invalidation_state_tracker.AsWeakPtr());
238 scoped_ptr<SyncNotifier> sync_notifier( 239 scoped_ptr<SyncNotifier> sync_notifier(
239 sync_notifier_factory.CreateSyncNotifier()); 240 sync_notifier_factory.CreateSyncNotifier());
240 NotificationPrinter notification_printer; 241 NotificationPrinter notification_printer;
241 242
242 const char kUniqueId[] = "fake_unique_id"; 243 const char kUniqueId[] = "fake_unique_id";
243 sync_notifier->SetUniqueId(kUniqueId); 244 sync_notifier->SetUniqueId(kUniqueId);
244 sync_notifier->UpdateCredentials(email, token); 245 sync_notifier->UpdateCredentials(email, token);
246
245 // Listen for notifications for all known types. 247 // Listen for notifications for all known types.
248 sync_notifier->RegisterHandler(&notification_printer);
246 sync_notifier->UpdateRegisteredIds( 249 sync_notifier->UpdateRegisteredIds(
247 &notification_printer, ModelTypeSetToObjectIdSet(ModelTypeSet::All())); 250 &notification_printer, ModelTypeSetToObjectIdSet(ModelTypeSet::All()));
248 251
249 ui_loop.Run(); 252 ui_loop.Run();
250 253
251 sync_notifier->UpdateRegisteredIds(&notification_printer, ObjectIdSet()); 254 sync_notifier->UnregisterHandler(&notification_printer);
252 io_thread.Stop(); 255 io_thread.Stop();
253 return 0; 256 return 0;
254 } 257 }
255 258
256 } // namespace 259 } // namespace
257 } // namespace syncer 260 } // namespace syncer
258 261
259 int main(int argc, char* argv[]) { 262 int main(int argc, char* argv[]) {
260 return syncer::SyncListenNotificationsMain(argc, argv); 263 return syncer::SyncListenNotificationsMain(argc, argv);
261 } 264 }
OLDNEW
« no previous file with comments | « sync/sync.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698