sync/internal_api/sync_manager_impl.h - Issue 10824161: [Sync] Avoid unregistering object IDs on shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_manager_impl.h

Issue 10824161: [Sync] Avoid unregistering object IDs on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Work around brittle unit test Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/sync_manager_impl.h

diff --git a/sync/internal_api/sync_manager_impl.h b/sync/internal_api/sync_manager_impl.h

index d9bd8abe76686b95167aed494ecc789a9d82a47a..1c4541fdf1b31b2ac5607dc19057d119834f23d0 100644

--- a/sync/internal_api/sync_manager_impl.h

+++ b/sync/internal_api/sync_manager_impl.h

@@ -87,9 +87,13 @@ class SyncManagerImpl : public SyncManager,

virtual void UpdateCredentials(const SyncCredentials& credentials) OVERRIDE;

virtual void UpdateEnabledTypes(

const ModelTypeSet& enabled_types) OVERRIDE;

+ virtual void RegisterInvalidationHandler(

+ SyncNotifierObserver* handler) OVERRIDE;

virtual void UpdateRegisteredInvalidationIds(

SyncNotifierObserver* handler,

const ObjectIdSet& ids) OVERRIDE;

+ virtual void UnregisterInvalidationHandler(

+ SyncNotifierObserver* handler) OVERRIDE;

virtual void StartSyncingNormally(

const ModelSafeRoutingInfo& routing_info) OVERRIDE;

virtual void SetEncryptionPassphrase(const std::string& passphrase,