Issue 10823392: Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823392: Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future c… (Closed)

Created:
8 years, 4 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
scottmg

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future change, but I wanted to break it up. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152102

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -19 lines)			Patch
M	chrome/browser/browser_focus_uitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_restore_browsertest.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/find_bar/find_bar_host_browsertest.cc	View		5 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/pdf/pdf_browsertest.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_host_interactive_uitest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View		4 chunks	+9 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

scottmg

8 years, 4 months ago (2012-08-17 17:20:47 UTC) #2

an extra NULL is exactly what that function needs! :P

lgtm