chrome/browser/ui/pdf/pdf_browsertest.cc - Issue 10823392: Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/pdf/pdf_browsertest.cc

Issue 10823392: Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future c… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_host_browsertest.cc ('k') | chrome/browser/ui/views/find_bar_host_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/pdf/pdf_browsertest.cc

===================================================================

--- chrome/browser/ui/pdf/pdf_browsertest.cc (revision 152084)

+++ chrome/browser/ui/pdf/pdf_browsertest.cc (working copy)

@@ -107,7 +107,8 @@

string16 query = UTF8ToUTF16(

std::string("xyzxyz" + base::IntToString(next_dummy_search_value_++)));

ASSERT_EQ(0, ui_test_utils::FindInPage(

- chrome::GetActiveTabContents(browser()), query, true, false, NULL));

+ chrome::GetActiveTabContents(browser()), query, true, false, NULL,

+ NULL));

}

private:

@@ -264,7 +265,7 @@

// Verifies that find in page works.

ASSERT_EQ(3, ui_test_utils::FindInPage(

chrome::GetActiveTabContents(browser()), UTF8ToUTF16("adipiscing"),

- true, false, NULL));

+ true, false, NULL, NULL));

// Verify that copying selected text works.

ui::Clipboard clipboard;