Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: chrome/browser/ui/views/find_bar_host_interactive_uitest.cc

Issue 10823392: Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future c… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/pdf/pdf_browsertest.cc ('k') | chrome/test/base/ui_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/find_bar_host_interactive_uitest.cc
===================================================================
--- chrome/browser/ui/views/find_bar_host_interactive_uitest.cc (revision 152084)
+++ chrome/browser/ui/views/find_bar_host_interactive_uitest.cc (working copy)
@@ -139,7 +139,7 @@
EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(),
VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
ui_test_utils::FindInPage(chrome::GetActiveTabContents(browser()),
- ASCIIToUTF16("a"), true, false, NULL);
+ ASCIIToUTF16("a"), true, false, NULL, NULL);
browser()->GetFindBarController()->EndFindSession(
FindBarController::kKeepSelectionOnPage,
FindBarController::kKeepResultsInFindBox);
@@ -182,7 +182,7 @@
// Search for 'a'.
ui_test_utils::FindInPage(chrome::GetActiveTabContents(browser()),
- ASCIIToUTF16("a"), true, false, NULL);
+ ASCIIToUTF16("a"), true, false, NULL, NULL);
EXPECT_TRUE(ASCIIToUTF16("a") == find_bar->GetFindSelectedText());
// Open another tab (tab B).
@@ -199,7 +199,7 @@
// Search for 'b'.
ui_test_utils::FindInPage(chrome::GetActiveTabContents(browser()),
- ASCIIToUTF16("b"), true, false, NULL);
+ ASCIIToUTF16("b"), true, false, NULL, NULL);
EXPECT_TRUE(ASCIIToUTF16("b") == find_bar->GetFindSelectedText());
// Set focus away from the Find bar (to the Location bar).
« no previous file with comments | « chrome/browser/ui/pdf/pdf_browsertest.cc ('k') | chrome/test/base/ui_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698