Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8034)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 10823392: Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future c… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_restore_browsertest.cc ('k') | chrome/browser/ui/pdf/pdf_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
===================================================================
--- chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (revision 152084)
+++ chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (working copy)
@@ -140,7 +140,7 @@
int* ordinal) {
return ui_test_utils::FindInPage(
tab, WideToUTF16(std::wstring(search_str)),
- forward, case_sensitive, ordinal);
+ forward, case_sensitive, ordinal, NULL);
}
// Calls FindInPageWchar till the find box's x position != |start_x_position|.
@@ -811,7 +811,7 @@
// Simulate what happens when you press F3 for FindNext. We should get a
// response here (a hang means search was aborted).
EXPECT_EQ(0, ui_test_utils::FindInPage(tab, string16(),
- kFwd, kIgnoreCase, &ordinal));
+ kFwd, kIgnoreCase, &ordinal, NULL));
EXPECT_EQ(0, ordinal);
// Open another tab (tab C).
@@ -821,7 +821,7 @@
// Simulate what happens when you press F3 for FindNext. We should get a
// response here (a hang means search was aborted).
EXPECT_EQ(0, ui_test_utils::FindInPage(tab, string16(),
- kFwd, kIgnoreCase, &ordinal));
+ kFwd, kIgnoreCase, &ordinal, NULL));
EXPECT_EQ(0, ordinal);
}
@@ -908,7 +908,7 @@
// Simulate what happens when you press F3 for FindNext. Still should show
// one match. This cleared the pre-populate string at one point (see bug).
EXPECT_EQ(1, ui_test_utils::FindInPage(tab, string16(),
- kFwd, kIgnoreCase, &ordinal));
+ kFwd, kIgnoreCase, &ordinal, NULL));
EXPECT_EQ(1, ordinal);
// End the Find session, thereby making the next F3 start afresh.
@@ -952,7 +952,8 @@
FindBarController::kKeepSelectionOnPage,
FindBarController::kKeepResultsInFindBox);
// Simulate F3.
- ui_test_utils::FindInPage(tab1, string16(), kFwd, kIgnoreCase, &ordinal);
+ ui_test_utils::FindInPage(tab1, string16(), kFwd, kIgnoreCase, &ordinal,
+ NULL);
EXPECT_EQ(tab1->find_tab_helper()->find_text(), WideToUTF16(L"text"));
}
« no previous file with comments | « chrome/browser/tab_restore_browsertest.cc ('k') | chrome/browser/ui/pdf/pdf_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698