Issue 10696173: Revert "Revert 146000 - Split out ContentViewCore from ContentView for embedders."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696173: Revert "Revert 146000 - Split out ContentViewCore from ContentView for embedders." (Closed)

Created:
8 years, 5 months ago by Ted C

Modified:
8 years, 5 months ago

Reviewers:
ericu

CC:
chromium-reviews, yusukes+watch_chromium.org, erikwright (departed), jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Revert 146000 - Split out ContentViewCore from ContentView for embedders." This reverts commit 331b803f65e8f994f9148024e8c2be6b465c6a6e. TBR=ericu@chromium.org BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146141

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebase number deux #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+591 lines, -1034 lines)			Patch
M	base/android/jni_generator/jni_generator.py	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	base/android/jni_generator/jni_generator_tests.py	View		7 chunks	+7 lines, -6 lines	0 comments	Download
M	content/browser/android/browser_jni_registrar.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/android/content_settings.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/android/content_view_client.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	content/browser/android/content_view_core_impl.h	View		5 chunks	+14 lines, -14 lines	0 comments	Download
A +	content/browser/android/content_view_core_impl.cc	View	1	15 chunks	+64 lines, -63 lines	0 comments	Download
D	content/browser/android/content_view_impl.h	View		1 chunk	+0 lines, -135 lines	0 comments	Download
D	content/browser/android/content_view_impl.cc	View		1 chunk	+0 lines, -307 lines	0 comments	Download
M	content/browser/android/download_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/android/download_controller.cc	View		4 chunks	+7 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.cc	View	1	11 chunks	+26 lines, -25 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_android.h	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_android.cc	View		4 chunks	+15 lines, -15 lines	0 comments	Download
M	content/content_browser.gypi	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/content_jni.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentSettings.java	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentView.java	View		19 chunks	+160 lines, -257 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java	View		1 chunk	+2 lines, -3 lines	0 comments	Download
A +	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1	24 chunks	+222 lines, -80 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/DownloadController.java	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ZoomManager.java	View		7 chunks	+17 lines, -16 lines	0 comments	Download
D	content/public/browser/android/content_view.h	View		1 chunk	+0 lines, -50 lines	0 comments	Download
A +	content/public/browser/android/content_view_core.h	View	1	3 chunks	+14 lines, -13 lines	0 comments	Download
M	ui/gfx/native_widget_types.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download