Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: base/android/jni_generator/jni_generator_tests.py

Issue 10696173: Revert "Revert 146000 - Split out ContentViewCore from ContentView for embedders." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase number deux Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_generator/jni_generator.py ('k') | content/browser/android/browser_jni_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_generator/jni_generator_tests.py
diff --git a/base/android/jni_generator/jni_generator_tests.py b/base/android/jni_generator/jni_generator_tests.py
index f0f68f97204303664af6adbff9c6657d38775dc5..1ce7a37dc605095faeff47479e92efa0a657ec0e 100755
--- a/base/android/jni_generator/jni_generator_tests.py
+++ b/base/android/jni_generator/jni_generator_tests.py
@@ -54,6 +54,7 @@ class TestGenerator(unittest.TestCase):
print '=' * 80
self.fail('Golden text mismatch')
+ # TODO(bulach): Detangle these tests from knowing about classes from Content.
def testNatives(self):
test_data = """"
private native int nativeInit();
@@ -64,7 +65,7 @@ class TestGenerator(unittest.TestCase):
private static native String nativeGetDomainAndRegistry(String url);
private static native void nativeCreateHistoricalTabFromState(
byte[] state, int tab_index);
- private native byte[] nativeGetStateAsByteArray(ContentView view);
+ private native byte[] nativeGetStateAsByteArray(ContentViewCore view);
private static native String[] nativeGetAutofillProfileGUIDs();
private native void nativeSetRecognitionResults(
int sessionId, String[] results);
@@ -125,7 +126,7 @@ class TestGenerator(unittest.TestCase):
type='function'),
NativeMethod(return_type='byte[]', static=False,
name='GetStateAsByteArray',
- params=[Param(datatype='ContentView', name='view')],
+ params=[Param(datatype='ContentViewCore', name='view')],
java_class_name=None,
type='function'),
NativeMethod(return_type='String[]', static=True,
@@ -359,7 +360,7 @@ static bool RegisterNativesImpl(JNIEnv* env) {
"V", reinterpret_cast<void*>(CreateHistoricalTabFromState) },
{ "nativeGetStateAsByteArray",
"("
-"Lorg/chromium/content/browser/ContentView;"
+"Lorg/chromium/content/browser/ContentViewCore;"
")"
"[B", reinterpret_cast<void*>(GetStateAsByteArray) },
{ "nativeGetAutofillProfileGUIDs",
@@ -754,7 +755,7 @@ static bool RegisterNativesImpl(JNIEnv* env) {
void dismiss();
@SuppressWarnings("unused")
@CalledByNative
- private static boolean shouldShowAutoLogin(ContentView contentView,
+ private static boolean shouldShowAutoLogin(ContentViewCore contentView,
String realm, String account, String args) {
AccountManagerContainer accountManagerContainer =
new AccountManagerContainer((Activity)contentView.getContext(),
@@ -826,7 +827,7 @@ static bool RegisterNativesImpl(JNIEnv* env) {
name='shouldShowAutoLogin',
method_id_var_name='shouldShowAutoLogin',
java_class_name='',
- params=[Param(datatype='ContentView', name='contentView'),
+ params=[Param(datatype='ContentViewCore', name='contentView'),
Param(datatype='String', name='realm'),
Param(datatype='String', name='account'),
Param(datatype='String', name='args')],
@@ -1061,7 +1062,7 @@ static void GetMethodIDsImpl(JNIEnv* env) {
"shouldShowAutoLogin",
"("
-"Lorg/chromium/content/browser/ContentView;"
+"Lorg/chromium/content/browser/ContentViewCore;"
"Ljava/lang/String;"
"Ljava/lang/String;"
"Ljava/lang/String;"
« no previous file with comments | « base/android/jni_generator/jni_generator.py ('k') | content/browser/android/browser_jni_registrar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698